linuxmint / cinnamon

A Linux desktop featuring a traditional layout, built from modern technology and introducing brand new innovative features.
GNU General Public License v2.0
4.48k stars 728 forks source link

keybindings: A new keybinding to a spice will only show up in the keyboard settings after closing and reopening the settings app #12293

Open anaximeno opened 2 months ago

anaximeno commented 2 months ago
  1. Open the settings app
  2. Add a new keybinding to an extension or applet
  3. Go to the Shortcuts section of the Keyboard settings module
  4. You'll notice that the new keybinding won't figure there
  5. Close and reopen the setting app
  6. Go to the Shortcuts section of the Keyboard settings module
  7. You'll notice that the new keybinding will be there now

The same happens if you remove a keybinding for the extension/applet while the settings module is open.

rcalixte commented 2 months ago

Is this unlike the other bindings? The same thing happens if you have multiple instances open and modify the binding in one window vs the other. Should we add some text to let it be clear that there is a single load? Maybe a 'Reload All' button?

anaximeno commented 2 months ago

Is this unlike the other bindings? The same thing happens if you have multiple instances open and modify the binding in one window vs the other. Should we add some text to let it be clear that there is a single load? Maybe a 'Reload All' button?

I don't see this as a big issue, since I don't know if the user will face this situation regularly so it could affect the UX. If the effort to implement a solution is not minimal we probably can let it go for this beta, or at least give it a lower priority.

I was thinking if we could listen to the add or remove keybindings (as a signal) and update the view, but add a refresh button could be a good solution as well.

rcalixte commented 2 months ago

Hmm. Signals would be nice. Right now, we're just reading in the configuration files and schema values. I think you're right that a smoother UX might be a little more complex. 😅

clefebvre commented 1 month ago

Moved to cinnamon.