linuxmint / cinnamon

A Linux desktop featuring a traditional layout, built from modern technology and introducing brand new innovative features.
GNU General Public License v2.0
4.57k stars 744 forks source link

Graphical glitch on lockscreen: the password field vibrates after an incorrect password. #12463

Open HT-7 opened 4 weeks ago

HT-7 commented 4 weeks ago

Distribution

Mint 21

Package version

5.4.8

Graphics hardware in use

No response

Frequency

Always

Bug description

The password field shakes up and down after pressing enter after typing an incorrect password.

Steps to reproduce

Type in an incorrect password in the login screen and then press enter.

Expected behavior

The password field should not move.

Additional information

I believe I have found the code that causes this bug:

unlock.py


def blink(self):
        GObject.timeout_add(75, self.on_blink_tick)

    def on_blink_tick(self, data=None):
        window = self.get_window()

        if window is None:
            return False

        x, y = window.get_position()

        if self.bounce_count < 6:
            if self.bounce_count % 2 == 0:
                y += 6
            else:
                y -= 6
            self.get_window().move(x, y)
            self.queue_draw()

            self.bounce_count += 1

            return True

        self.bounce_count = 0
        return False  

This bounce animation adds no value. All it does is rub an unwelcome fact in the face of the user.

Errors are the annoying part of using computers. Please don't add emphasis to them. Emphacised errors are the last thing computer users need. Add emphasis to successes instead.

The user is annoyed enough by having to retype a password. The last thing they need is having the login dialogue do a clownish dance in their face. The fact that the user sees a lock screen infront of them rather than their desktop is more than enough visual feedback that they entered a wrong password.

My experience with Linux Mint is overwhelmingly positive, but this shaking effect is undesirable. I have at this point developed the habit of closing my eyes when pressing Enter to avoid having this eyesore in my face.

This bouncing effect adds no value. All it does is rubbing an error into the face of the user. I doubt anyone enjoys it. It is nonsense invented by Apple. We don't need clownish Apple nonsense imported into the Linux world. It is nothing but bloat. Please get rid of it.

Thank you for your consideration, and thank you for creating this otherwise good OS.