search

linuxmint / cinnamon

A Linux desktop featuring a traditional layout, built from modern technology and introducing brand new innovative features.
GNU General Public License v2.0
4.57k stars 744 forks source link

sound applet: player icon should not take priority over mute icon #12502

Closed benmccann closed 6 days ago

benmccann commented 6 days ago

closes https://github.com/linuxmint/cinnamon/issues/12393

leigh123linux commented 6 days ago

@claudiux Why are you merging commits without discussing them with the team first!!

claudiux commented 6 days ago

@leigh123linux I've tested these commits and they work well. It seems to me that the team had other problems to solve.

JosephMcc commented 5 days ago

@claudiux but you don't even know if this was a change that was wanted without any discussion. That's the point. Maybe it was and this is the right solution. But typically that decision is something that is cleared first.

claudiux commented 5 days ago

@JosephMcc When a PR solves a problem that has not been closed (cause: unplanned), it seems to me that this PR should be accepted.