linuxmint / cinnamon

A Linux desktop featuring a traditional layout, built from modern technology and introducing brand new innovative features.
GNU General Public License v2.0
4.5k stars 732 forks source link

[Bug] Very short-lived windows cause stuck "dead window" #1316

Closed areynaldos closed 10 years ago

areynaldos commented 11 years ago

Issue #340 explains the problem in detail, related to short-lived windows leaving behind a "ghost" window.

The original fix by ebbes works correctly. I am using Cinnamon 1.6.4 and the problem is still around. However, if I apply ebbes fix to windowManager.js the problem disappears.

Humbly, I think that Clem's refactoring is not 100% equivalent to the "working" ebbes fix.

Changes in commit b28d90265e65e48a0168e33a550cc1b364bbcb40 works for me, while 19f1b97b0510c6e8f27a8d78a600d11d03c9fcf5 doesn't.

areynaldos commented 11 years ago

Issue 1102 was dismissed as a duplicate of #340 also, but then again, the problem is still around.

AlbertJP commented 11 years ago

Please tell in which program you are having this problem.

I have fixed the links to the commits in your message (the latter one was dead). It's sufficient to put the commit ID here, no need to write a link manually.

areynaldos commented 11 years ago

Thanks @AlbertJP

Today I updated Cinnamon to 1.6.7 and the problem is still there.

Right now I have it when opening Eclipse. The first window that opens says "Progress Information", and then lingers as the infamous "ghost window" in front of everything else

I also have it in SmartGit, depending on the task. I can attach an image of the problem if needed.

As mentioned above, If I apply ebbes's changes from b28d902 to windowManager.js the problem is solved.

csibi1979 commented 11 years ago

I have this bug too. In Cinnamon 1.6.7 on Linux Mint Maya, if I open connection in MySQL Workbench the splash stays on screen.

areynaldos commented 11 years ago

csibi1979, you can get rid of the problem by either implementing ebbes changes to the windowManager.js that I mention, or by restarting Cinnamon (Alt-F2, then type "r").

mateolan commented 11 years ago

I can confirm that this was a problem mostly with java programs, and was fixed with ebbes changes as well

katoquro commented 11 years ago

:up: without patch from @areynaldos work with applications with many short-lived progress windows is impossible

areynaldos commented 11 years ago

@katoquro: I am sharing my version of windowManager.js here.

It is just a merge between the official Cinnamon 1.6.7 version and @ebbes change (removing the code that he removed to fix the issue).

There is no assurance that it will work, and you use it under your own risk. Usual disclaimers apply. I've been using it since 1.6.7 was available and hasn't created any problems FOR ME.

Until the original problem is fixed (the issue was closed but the problem is still around) I guess it is the only way of sharing a script that does resolve the problem.

AlbertJP commented 11 years ago

@areynaldos Feel free to create a pull request for your patch. An easy way to do so is by browsing to windowManager.js on GitHub and clicking Edit. At the bottom you can put the title of your commit - please do not use the default "Update js/ui/windowManager.js" title. Then after committing the code, you'll be offered to create a pull request.

areynaldos commented 11 years ago

Thanks @AlbertJP , will do so. What I am afraid of is that I only what fixes the problem, but I don't know what are possible side-effects to the change in the code. Would somebody more senior do a code-check before pulling?

dalcde commented 11 years ago

@areynaldos After you make the pull request, we'll check it before merging.

areynaldos commented 11 years ago

Before attempting to fix the code, I tried the windowManager.js version from Cinnamon 1.6.7 (the last release, without the patch) and I haven't seen the dead ghost windows anymore.

Since I was using my patched version I don't know when it was fixed, but maybe one of the latest Xorg updates that have come was responsible for the fix. As of myself, I'll keep the issue open for a while, but will close as the reporter if I can't reproduce within the next few days.

katoquro commented 11 years ago

I can reproduce this bug on archlinux (aur/cinnamon 1.6.7-4) only with fade out effect. When I use scale (or disable) effects for closing window all works fine.

bluzee commented 11 years ago

It happens to me with with desktop effects turned off as well as with desktop effects turned on.

I-sty commented 11 years ago

Me too, with the compress dialog, and the WingIDE's debugger dialog.

nymo commented 11 years ago

Have the same problem in archlinux and cinnamon 1.6.7-5. When I turn the fade out effect off then the problem is gone.

dawez commented 11 years ago

Bug is happening with Anki when you sync AnkiWeb. There is a short-lived window that is opening up and the it is stuck empty.

Removing fade when closing windows from effect control page is avoiding the issue. Using "scale" or "none" is also avoiding the issue.

I-sty commented 11 years ago

With dawez idea, now, for me the extrac dialog isn't crashed.

AlbertJP commented 11 years ago

Ok, so when #340 got closed, only scale was fixed, not fade... Scale is default so perhaps that's why this was not seen.

ghost commented 11 years ago

In previous cinnamon versions I had this fixed from a patch to windowManager.js, however after upgrading to 1.8.2 the issue is back.

ghost commented 11 years ago

Setting the close effect to none prevents this from happening.

warp27 commented 11 years ago

I can confirm handuel's suggestion fixes this issue in my computer.

demonkoryu commented 11 years ago

Still, that's only a workaround, not a fix.

bhavyanshu commented 11 years ago

I can confirm that the "Closing Windows" effect when changed to "Scale" completely solved the issue for me.

msasa commented 11 years ago

After last Cinnamon update the issue is still here. Areynaldos' solution is no longer ok :( . If you now try to replace windowManager.js, cinnamon is going to crash and cannot restart. You can repair crashed Cinnamon only if you restore old version of the file, which still has the bug.

PerfMonk commented 11 years ago

I'm on Linux 15 Mint Cinnamon with all updates applied up to today and I still have that problem too. Is there someone working on a solution soon ?

It's rather ennoying, i get dead windows at least 5 times a day at least. And I have to deconnect/reconnect to get rid of the dead window.

Thanks, BT

bhavyanshu commented 11 years ago

@PerfMonk "Closing Windows" effect needs to be changed to "Scale". I know it is a workaround but you can use this until it gets fixed.

areynaldos commented 11 years ago

@PerfMonk the workaround mentioned above is the way to go... but you don't have to "disconnect/reconnect" which I assume means logout/login... You can just restart Cinnamon with ALT-F2, r . Or using the "Restart Cinnamon" option from the Troubleshooting in the Cinnamon Settings Applet.