linuxmint / cinnamon

A Linux desktop featuring a traditional layout, built from modern technology and introducing brand new innovative features.
GNU General Public License v2.0
4.52k stars 734 forks source link

"Configure" option for menu applet in panel not working #8801

Closed UncleSpellbinder closed 5 years ago

UncleSpellbinder commented 5 years ago

Issue Clicking "configure" no longer works, nothing happens. The "About" and "Remove Menu" options both work, as the dialog boxes are shown after clicking those. When I click "configure", nothing happens. All other applets in the panel that have a "configure " option work as expected.

Steps to reproduce Right click menu applet, select "configure".

Expected behaviour Configure dialog box should appear.

Other information I tried with two other menu applets (Cinnamenu and CinnVIIStarkMenu). Same issue with both of those as well, "About" and "Remove Menu" both work as the dialog boxes are shown after clicking those. When I click "configure", nothing happens.

JosephMcc commented 5 years ago

Do your logs or .xsession-errors show anything that might be related? I can't reproduce the issue here on Mint 19.2.

UncleSpellbinder commented 5 years ago

I can copy/paste here. It's quite long. I couldn't sus anything out.

JosephMcc commented 5 years ago

Please do or put it in pastebin or something. Thanks

UncleSpellbinder commented 5 years ago

Here's the Pastebin link: https://pastebin.com/TNbMu7Qq

JosephMcc commented 5 years ago

Thanks. Nothing stands out for me in there. Maybe someone else will see something.

JosephMcc commented 5 years ago

Could you try running xlet-settings applet menu@cinnamon.org with the stock menu in the panel. This should show it's settings or give you an error of some kind.

UncleSpellbinder commented 5 years ago
[daveb@archlinux ~]$ xlet-settings applet menu@cinnamon.org
Segmentation fault (core dumped)
[daveb@archlinux ~]$ 
UncleSpellbinder commented 5 years ago

Using sudo, there is more info...

[daveb@archlinux ~]$ sudo xlet-settings applet menu@cinnamon.org
[sudo] password for daveb: 
Traceback (most recent call last):
  File "/usr/share/cinnamon/cinnamon-settings/xlet-settings.py", line 554, in <module>
    window = MainWindow(xlet_type, *sys.argv[2:])
  File "/usr/share/cinnamon/cinnamon-settings/xlet-settings.py", line 144, in __init__
    self.load_instances()
  File "/usr/share/cinnamon/cinnamon-settings/xlet-settings.py", line 260, in load_instances
    dir_items = sorted(os.listdir(path))
FileNotFoundError: [Errno 2] No such file or directory: '/root/.cinnamon/configs/menu@cinnamon.org'
[daveb@archlinux ~]$ 
mtwebster commented 5 years ago

are there any entries in the "System Reports" app (in the menu) or run 'mintreport`. Look under "Crash reports"

claudiux commented 5 years ago

@UncleSpellbinder Do not use sudo. The root user does not use this applet.

claudiux commented 5 years ago

@UncleSpellbinder Can you try: cinnamon-settings applets menu@cinnamon.org?

UncleSpellbinder commented 5 years ago
[daveb@archlinux ~]$ cinnamon-settings applets menu@cinnamon.org
Segmentation fault (core dumped)
[daveb@archlinux ~]$
UncleSpellbinder commented 5 years ago

mtwebster, there is no "System Reports" app. I suspect running "mintreport" will not help, I'm running Arch.

mtwebster commented 5 years ago

oh sorry I didn't pay attention to original post :)

You'll have to debug it - this link should help:

https://github.com/linuxmint/Cinnamon/wiki/How-to-use-GDB-to-gather-debug-information-on-a-program

smurphos commented 5 years ago

What icon theme do you have set. I ask as a Mint user reported a similar issue on the forums and it appears the Yaru++ icon theme was a factor.

https://forums.linuxmint.com/viewtopic.php?f=90&t=299968

UncleSpellbinder commented 5 years ago

What icon theme do you have set. I ask as a Mint user reported a similar issue on the forums and it appears the Yaru++ icon theme was a factor.

https://forums.linuxmint.com/viewtopic.php?f=90&t=299968

WOW. You are correct! I was using the Korla icon theme. Switched to Arc. "Configure" works as expected.

I'm so sorry to have wasted everyone's time.

Thanks for the info, smurphos!

UncleSpellbinder commented 5 years ago

SOLVED

smurphos commented 5 years ago

It's not a waste of time. It may be an icon theme related bug, but it should not make the settings module crash if it is.

The Yaru++ theme is from https://github.com/Bonandry/yaru-plus

I got as far as reproducing the crash with the Yaru++ theme on Mint, but haven't investigated any furhter

JosephMcc commented 5 years ago

This should be fixed by: https://github.com/linuxmint/xapps/commit/b325768013de6c42f743df58415be24c8e94ed87

eli-schwartz commented 5 years ago

@UncleSpellbinder I'm uploading the new xapps version to Arch's community repository as we speak, so your original icon theme should work now I guess.

pacman -Syu 'xapps>=1.4.9-1'

smurphos commented 5 years ago

This should be fixed by: linuxmint/xapps@b325768

Partially fixed - you still can't open the icon picker GUI from the configure GUI with one of the problematic icon themes.

cinnamon-desktop-editor is also broken by these icon themes

steve@steve-Inspiron-5580:~$ cinnamon-desktop-editor -m nemo-launcher -d ~/Desktop

Segmentation fault (core dumped)

Edit to add - can reproduce with the korla icon theme as used by the OP - https://github.com/bikass/korla

mtwebster commented 5 years ago

There's nothing we can do with this other than isolating it as much as possible, which that patch did, this is a gtk issue.

https://gitlab.gnome.org/GNOME/gtk/issues/2111

smurphos commented 5 years ago

Thanks @mtwebster - I'm not sure if it's relevant for your upstream bug report, but fixing the typo in the index that produces the warning doesn't eliminate the seg-fault.

UncleSpellbinder commented 5 years ago

@UncleSpellbinder I'm uploading the new xapps version to Arch's community repository as we speak, so your original icon theme should work now I guess.

pacman -Syu 'xapps>=1.4.9-1'

@eli-schwartz - Thanks. As was mentioned, it's partially fixed as I can't open the icon picker GUI from the configure GUI. But, some progress is better than none. Much appreciated.

gusbemacbe commented 4 years ago

Hi @smurphos !

I am co-author of Yaru++. It had "no size field", because the author of icons theme used the old version of Suru++ Ubuntu, which caused bugs in the Yaru++ theme.

During a month, I have worked, fixed and upgraded the whole Yaru++. I have already told him not to copy or use the old version of Suru++ Ubuntu for his new icons themes.

I have just released the new version today. You can check and test.

Davetheraveuk commented 4 years ago

Hi, I am having the same problem as OP. Here is my terminal output:


[dave@RebornOS Desktop]$ cinnamon-settings applets menu@cinnamon.org
Traceback (most recent call last):

  File "/usr/share/cinnamon/cinnamon-settings/xlet-settings.py", line 17, in <module>
    from JsonSettingsWidgets import *

  File "/usr/share/cinnamon/cinnamon-settings/bin/JsonSettingsWidgets.py", line 332, in <module>
    globals()["JSONSettings"+widget] = json_settings_factory(widget)

  File "/usr/share/cinnamon/cinnamon-settings/bin/JsonSettingsWidgets.py", line 313, in json_settings_factory class NewClass(globals()[subclass], JSONSettingsBackend):

KeyError: 'SoundFileChooser'

Dunno what is causing this. Let me now if you require any more info. Dave.

pawanneupane commented 4 years ago

Hi, I am having the same problem as OP. Here is my terminal output:


[dave@RebornOS Desktop]$ cinnamon-settings applets menu@cinnamon.org
Traceback (most recent call last):

  File "/usr/share/cinnamon/cinnamon-settings/xlet-settings.py", line 17, in <module>
    from JsonSettingsWidgets import *

  File "/usr/share/cinnamon/cinnamon-settings/bin/JsonSettingsWidgets.py", line 332, in <module>
    globals()["JSONSettings"+widget] = json_settings_factory(widget)

  File "/usr/share/cinnamon/cinnamon-settings/bin/JsonSettingsWidgets.py", line 313, in json_settings_factory class NewClass(globals()[subclass], JSONSettingsBackend):

KeyError: 'SoundFileChooser'

Dunno what is causing this. Let me now if you require any more info. Dave.

I'd been facing the same issue in Arch Linux for the past couple of days. The latest cinnamon update seems to have fixed it.

leigh123linux commented 4 years ago

@pawanneupane @Davetheraveuk

https://github.com/linuxmint/cinnamon/issues/9305

pawanneupane commented 4 years ago

@leigh123linux Thanks. Updated Cinnamon and everything's working fine again. Cheers!

Davetheraveuk commented 4 years ago

@pawanneupane @leigh123linux Yup. Can confirm, all is good. Thanks guys. Dave.