linuxmint / jargonaut

Easy to use Chat Room application
GNU General Public License v2.0
68 stars 6 forks source link

Fix notification text #4

Open carlosmintfan opened 4 months ago

carlosmintfan commented 4 months ago

We previously got html-escaped text and our added link/image HTML all in the notification, which didn't look very nice. Will fix: #7

clefebvre commented 4 months ago

We can't allow HTML tags to get into the notification. What we can do though is remove them altogether.

i.e. we escape them for webkit, and remove them for notify.

carlosmintfan commented 4 months ago

We can't allow HTML tags to get into the notification. What we can do though is remove them altogether.

i.e. we escape them for webkit, and remove them for notify.

Why exactly?

carlosmintfan commented 4 months ago

We can't allow HTML tags to get into the notification. What we can do though is remove them altogether. i.e. we escape them for webkit, and remove them for notify.

Why exactly?

@clefebvre Ah, Notify supports some HTML in the notifications but isn't happy with escaping...is there an option to forbid Notify to parse text as HTML?