search

linuxmint / jargonaut

Easy to use Chat Room application
GNU General Public License v2.0
68 stars 6 forks source link

Light/Dark theme adaptability is gone. #6

Open Harry-W-Haines-III opened 4 months ago

Harry-W-Haines-III commented 4 months ago

System is: Linux Mint 21.3 Cinnamon Edition fully updated.

On a previous release Jargonaut had perfect adaptability to the change from a light to dark theme. Now that is gone and you have to manually toggle the switch "Prefer dark mode".

Light Theme: image

Dark Theme: image

Notice the large white area. Could we please restore that feature?

mtwebster commented 4 months ago

Seems fine on the latest build - https://github.com/linuxmint/jargonaut/releases

Nothing has been changed in jargonaut related to this

Harry-W-Haines-III commented 4 months ago

I'll remove everything from my system and re-install the official release.

Harry-W-Haines-III commented 4 months ago

Even after removing all traces and the .cache files and re-installing the official version it still has the same issue on my system.

Harry-W-Haines-III commented 4 months ago

Here are the steps to reproduce the issue. Boot off a USB live session. Eliminates the possibility of a 'contaminated' system. Switch to a dark theme. Install the latest version posted in GitHub. Everything will be dark when you open the app. Observe that the switch is thrown to 'Prefer dark mode'. Bur you are already in dark theme. Turn the 'Prefer dark mode' switch off. Switch to a light theme like Mint-X light. Then switch back to a dark them and the issue is present.

Because I switch at night and then again in the morning from light to dark theme, this issue was not present in some of the earlier releases. It was perfectly adaptable to a dark theme without having to do anything.

Harry-W-Haines-III commented 4 months ago

Confirmed this issue occurred after release 1.0.7

senpos commented 4 months ago

I can confirm the current behavior is a bit broken.

From my understanding, Prefer dark mode toggle in Preferences makes sure that the app is always using dark mode, even if the global GTK theme is light.

However, if you toggle your global dark theme on (for example, using "Desktop Colors" feature in the "Welcome" application), manually go to the Preferences in jargonaut, toggle Prefer dark node on and then toggle it off, the chat window will use light theme, despite dark theme being used globally.

That's because update_dark_mode function totally ignores the global (GTK) theme value and uses the app's (jargonaut) Prefer dark mode value to make the decision what theme should be used. https://github.com/linuxmint/jargonaut/blob/544d7614f4b185305e078014d0c491f2ab4e78ac/usr/lib/jargonaut/jargonaut.py#L674

I will send a patch.

senpos commented 4 months ago

OK, I don't really know how to properly fix this without accessing the currently used theme (mixed/dark/light).

Just for reference, I will share a video with reproduction of the issue mentioned by @Harry-W-Haines-III:

https://github.com/linuxmint/jargonaut/assets/9695470/86fdb832-35f6-4835-8aae-26c02c9bb722

It is very annoying that the same flag is being changed from both settings app and the app toggle itself. :(

mtwebster commented 4 months ago

We can reproduce it and it will get fixed sooner or later.