search

linuxmint / lightdm-settings

A configuration tool for the LightDM display manager
GNU General Public License v3.0
107 stars 24 forks source link

Feature request: Show previews in the theme choosers #61

Open linewelder-old opened 8 months ago

linewelder-old commented 8 months ago

Hello,

My suggestion is to show previews in the theme choosers like in the Themes section in settings. It's a small feature, but a very neat one in my opinion.

I tried adding this myself, but my solution depended on ChooserButtonWidgets.py from cinnamon-settings. I don't like this, but I see only two other ways to implement that:

  1. Merge lightdm-settings into cinnamon-settings and leave the dependency there.

  2. Copy the PictureChooserButton class to lightdm-settings (or at least the relevant parts).

I'm ready to work on this myself, but I need advice on addressing that problem.

clefebvre commented 1 month ago

I wouldn't invest time into this if I were you. Although it's a nice feature it's not really needed.

This is an Xapp, it can't be tied to Cinnamon Settings. You could duplicate the Cinnamon buttons, but there's a lot of work in there to make this work.. I don't know, with GTK5 talking about removing theme supports and all, I'm not sure it's the best time to spend resources on something like this.