search

linuxmint / lightdm-settings

A configuration tool for the LightDM display manager
GNU General Public License v3.0
113 stars 24 forks source link

[WIP] Add option to enable onscreen keyboard #62

Open Jakko3 opened 11 months ago

Jakko3 commented 11 months ago

Fixes: #59

I haven't considered translations. How is the procedure about them?

Marking as draft because the PR depends on slick-greeter PR https://github.com/linuxmint/slick-greeter/pull/229.

Jakko3 commented 11 months ago

Actually this new switch "On-screen keyboard" and the aldready existing selection list "On-screen keyboard" are in a section called "Panel indicators".

switch_onscreen_keyboard

It would be better to create a new section "On-screen keyboard" above section "Panel indicators" and move the new switch and the existing layout selection list there.

Jakko3 commented 11 months ago

Moved new switch and layout list into a new section "On-screen keyboard". The diff looks a bit confusing now – for the settings window, however, it makes sense:

section_onscreen_keyboard

Jakko3 commented 11 months ago

Removed the the related issue number #59 from the commit message because this emitted a message to this issue every time a change was done to the commit.

Jakko3 commented 11 months ago

For better readability of the diffs I split the changes into two separate commits: first create a new section for onscreen keyboard, then add the option to enable it.

Jakko3 commented 11 months ago

A comment on the pictures, the default is onscreen keyboard off and layout "Small":

default_onscreen_keyboard