search

linuxmint / live-installer

A live installer for the Debian edition
55 stars 65 forks source link

[Refactoring] Replaced commands.getoutput and subprocess.Popen with utils.* replacements #55

Closed kernc closed 6 years ago

kernc commented 10 years ago

Looking to be forward-compatible, commands module is not in Python 3 and it's good to have things a bit unified. Also allows for one central place to print debug messages of what is going on.

kernc commented 10 years ago

The most substantial change is that commands.getoutput() also caught any stderr output which this implementation doesn't, thankfully.

kernc commented 9 years ago

This has also been rebased, hopefully you can give it a look, and you approve.

kernc commented 6 years ago

@clefebvre You don't like the change?

clefebvre commented 6 years ago

Hi @kernc,

I do, it's just been sitting there since 2015, waiting to be tested and it's something I can do easily when we port it to python3. I thought it was time to either merge it or be done with it, and we're not ready to test so it's time to clean up.

kernc commented 6 years ago

But it's a clean effort towards Python 3 and there aren't any dense, structural changes involved. Why close it outright? I can work on it if there is something to be addressed.