linuxmint / live-installer

A live installer for the Debian edition
55 stars 65 forks source link

Timezone selection screen #59

Closed kernc closed 9 years ago

kernc commented 10 years ago

This commit introduces the following changes:

Let me know what you think.

corbin-auriti commented 10 years ago

instead of a salelight image or hight map, could you match the Ubuquity timezone image for consistancy? http://www.blackviper.com/images/Articles/OS/Install_Ubuntu_9_10/images/Install_Ubuntu_9_10_04_png.jpg

kernc commented 10 years ago

could I or would I? :smiley: is this a consensus? I wasn't actually trying to match ubiquity in any way and I consider, with exception of time displayed right on the map (done) and more up-to-date timezone bands (looking into it), my additions far superior. :stuck_out_tongue:

kernc commented 10 years ago

Ok, I moved the current time label next to the "dot" pointer, which is no longer a red cross (our map is not a treasure map!) but instead one of the standard map pins everybody is used to. I did investigate how ubiquity does it, and it so happens that for Gtk variant, it uses Gnome's Timezone selection which faces all the same challenges of out-of-date timezone overlays. (FWIW, I've checked the UTC+0..10 and they are equally wrong in places as those we have now.) Once live-installer sets to use gi.repository or as long as they use the same bg map and, assuming, update those overlays, we can rely on those, but for the time being, the calculated time is perfectly correct, the timezone map looks good, and I would consider this branch feature complete.

kernc commented 10 years ago

Ok, one issue I noticed with LMDE201404 Mate with default Mint-X theme. The GtkEventBox holding the current time label is not black as is set but has some white to black gradient instead. The problem seems to be in /usr/share/themes/Mint-X/gtk-2.0/gtkrc, line 273: widget_class "*<GtkNotebook>*<GtkEventBox>" style "notebook-fix". I don't know how crucial the line is or what it was supposed to "fix," but with this line commented out, everything looks correct (great) as does with any other theme. :smiley:

monsta commented 10 years ago

The theme issue seems to be fixed in https://github.com/linuxmint/mint-themes/commit/640f8ed15e2b7521dda5d13d19944f731cf06af9#diff-216 (warning, the commit is huge). No more "notebook-fix" entries anywhere. LMDE currently uses quite an old version of Mint-X theme.