linuxmint / live-installer

A live installer for the Debian edition
55 stars 65 forks source link

Drop configobj dependency #62

Closed kernc closed 9 years ago

kernc commented 10 years ago

Since our need for config parsing is minimal, and if we drop the only section in our config file (and make the keys global), everything can be covered in a few lines of code, hence the configobj dependency is redundant. :)

clefebvre commented 10 years ago

Two things..

It's a bit cryptic and it's something we could do elsewhere. I'd suggest adding this to mint-common instead.

kernc commented 10 years ago

What is cryptic?! Only the regex is cryptic (as it ought to be), but I assure it's as robust as possible, provided the assumptions hold true. But it's a simple 10-line function, surely not worth a dependency. And moreover, I coded it with full insight into what little config parsing is done here; I expressly advise against using it for general configuration parsing. It might bite you sometime later. :smiley: I would, however, drop tracking configobj from mint-common.