search

linuxmint / live-installer

A live installer for the Debian edition
57 stars 65 forks source link

More concise /etc/fstab generation #66

Closed kernc closed 9 years ago

kernc commented 9 years ago

It now much more closely follows the previous behavior. Are there any specific concerns you have with the code?

I also added a few comments to make it more transparent what is going on.

I don't think the slight differences are harmful in any way:

  1. Besides fsck-ing rootfs (/), also a separate /home is checked (2), as well as any other partition (there are many /sbin/fsck.* available, provided appropriate *{tools,progs,utils} package is installed as it should be). Except ntfs and swap partitions. The former has /bin/ntfsck and ntfsfix which the authors don't recommend, and the latter needs no checking, I suppose.
  2. And the other difference is swap being mounted with defaults instead of sw. But it works the same.
clefebvre commented 9 years ago

We can tackle the few improvements in separate PRs:

I don't want to merge the refactoring though so I'm closing this one.