btrfs-subvolume-support

orcus-de commented 5 years ago

The lmde3 setup does not support /@ and (optional) /@home subvolumes with btrfs - which is required to enable the usage of timeshift btrfs-snapshots.

added /@ and /@home as selectable mountpoints
modified test on / being available for install
using /@ requires to (re) format with btrfs - test and error-message
using /@home requires either (the pre-existing partition) being already formatted as btrfs, or (re) format with btrfs on setup

orcus-de commented 5 years ago

Did I miss some required step, to get it reviewed? (@xenopeek: yes you did react as fast as possible) But ... since then nothing did happen at all, which does surprise me a bit, as I've been asked to add a pull-request after closing lmde3 beta (which in turn made my description + a given workaround (using an expert setup) inaccessible for others).

xenopeek commented 5 years ago

I moved the issue to in progress on our issue planner while working through the list of open issues; it was coincidence that I was this quick. I'm not familiar with this code though. Requesting a review by Clem.

clefebvre commented 5 years ago

Hi @orcus-de sorry, it looks good. We're in the middle of the 19.1 release and this is LMDE so it's not as urgent, but it has every chance to get in before the next LMDE ISO release.

orcus-de commented 5 years ago

merci - xenopeek and clem :-) Although it's technically working by adding further mount-points to the list (as I did try to avoid to rework the partition-gui as much I could myself - it might be less confusing for regular users to offer the /@ and /@home subvolume option only if btrfs is used at all (instead to the current checking afterwards). ... but this would require a more interactive gui - either by

1) limit available selections of the "counter-part" a) offering /@ and /@home only in case btrfs has been selected b) (the other way round) limit available fs-trype to btrfs after selection of /@ or /@home

2) like 1) but instead of reducing the selections - highlight the "matching" counterpart

3) (my favorite) - remove the /@ and /@home subvolume from the dropdown-list and offer an additional checkbox which does show up only in case a combination of btrfs and one of / or /home has been given - to offer "use subvolume support for timeshift snapshots" ...

Have fun with the 19.1 beta in the meantime - orcus

orcus-de commented 5 years ago

For the ones interested in testing it - short writeup @how to grab & use the modifications from a live-mint:

https://www.orcus.de/main_workarounds/lmde3_btrfs_setup.htm

Be aware: this is not meant to be used on a production-system and requires a (re-) install of lmde3.

Have fun - orcus

orcus-de commented 5 years ago

damn ... using the wrong button

clefebvre commented 5 years ago

Thanks @orcus-de,

I'm going to merge it. The code looks code and we'll get more/easier testing if people can build directly from master.

linuxmint / live-installer

btrfs-subvolume-support #94