Mint-Y-Dark have some icons with low contrast in buttons - Githubissues

linuxmint / mint-19.1-beta

BETA Bug Squah Rush

3 stars 3 forks source link

Mint-Y-Dark have some icons with low contrast in buttons #67

Closed otavioschwanck closed 5 years ago

otavioschwanck commented 5 years ago

Describe the bug Some icons dont contrast well.

To Reproduce Steps to reproduce the behavior:

Enable icons on buttons

Expected behavior More white symbolic icons in dark theme.

Frequency Does the issue happen:

[x] Always
[ ] Randomly

Edition (Desktop environment): In which edition is this happening?

[x] Cinnamon Edition
[ ] MATE Edition
[ ] Xfce Edition

Live or post-install: Indicate if this is happening after the installation, or during the live session:

[x] Post-install
[x] Live session

Screenshots Chrome dialog: Gnome Terminal close icon: Transmissions icons: Gimp: Application Editor:

Clicking on window title, the symbolic icons are dark:

Xed plugins:

clefebvre commented 5 years ago

I fully agree with this, though I need to close it because it's a long term effort, not something that will be fixed this release.

These aren't symbolic icons, and that's the problem. They're fullcolor icons and there's no other way to make fullcolor work with dark and bright themes than to make them colorful, and that's hard to do, or it looks ugly.

What the icon theme is doing at the moment is to use some kind of grey which is visible both on dark and on light, it's a compromise. Ideally we should have -dark icon themes (but we're starting to have quite many already), or move to symbolic icons everywhere (and we do, a lot, but we can't force upstream to do the same).