search

linuxmint / mint-themes

Mint-X, Mint-Y..
207 stars 118 forks source link

Dark variant of Mint-Y themes break when setting org.gnome.desktop.inferface.color-scheme to "Prefer-Dark" #420

Closed AchillesBoi closed 1 year ago

AchillesBoi commented 1 year ago

When using the dark variant of Mint-Y themes, libadwaita apps remain in Light mode. To make libadwaita apps switch to Dark mode, one must change org.gnome.desktop.inferface.color-scheme to "Prefer-Dark". This in turn breaks Mint-Y themes but only the Dark variants; regular GTK3 apps will display in the old classic Adwaita theme instead of Mint-Y.

JosephMcc commented 1 year ago

Mint themes doesn't currently support libadwaita.

AchillesBoi commented 1 year ago

I understand Mint-Y themes don't support libadwaita. The issue is that Mint-Y breaks when setting libadwaita apps to Dark mode, making GTK3 apps fallback to the old GNOME 3 Adwaita theme instead of respecting the chosen Dark variant of Mint-Y.

Basically, if users want to use the Dark variants of Mint-Y then they need to use the Light variant of libadwaita apps. If users enable the Dark variant of libadwaita apps then the Dark variant of Mint-Y breaks and will instead fallback to GTK 3 Adwaita. This cannot be intended behavior since other themes like Yaru or even Adw-GTK do not have this issue.

AchillesBoi commented 1 year ago

This seems to be a fairly easy-to-fix issue but strangely no discussion about it so far...

Uldreth commented 1 year ago

Apparantly this issue is caused by GTK expecting dark variants to end in -dark (with an uncapitalized "dark" even).

A quick workaround is to copy eg. /usr/share/themes/Mint-Y-Dark-Aqua to /usr/share/themes/Mint-Y-Aqua-dark and in the directory change the index.theme accordingly. Then this issue will be gone, but GTK3 flatpak applications will no longer recognize the theme, which can be worked around via stylepak.

The Mint themes should be renamed upstream so that all dark variants end in "-dark".

mtwebster commented 1 year ago

The OP's issue will be addressed in Mint 21.2 by the new xdg-desktop-portal-xapp package.

ref: https://wiki.archlinux.org/title/XDG_Desktop_Portal