search

linuxmint / mint-themes

Mint-X, Mint-Y..
210 stars 123 forks source link

Fix text selection on unfocused windows #445

Closed schorschii closed 1 year ago

schorschii commented 1 year ago

The current Mint themes in 21 and 21.1 have a major issue: selected text is not visible as soon as the window loses the focus: Bildschirmfoto vom 2023-06-02 14-46-51

This fix brings back the behavior of Mint 20.3 where the text selection is visible even if the window is not focused.

The additional image { ... } is necessary to keep the white background, otherwise it will look like this: Bildschirmfoto vom 2023-06-02 15-45-58

fixes #438

JosephMcc commented 1 year ago

You need to be careful here to make sure you haven't reintroduced another issue: https://github.com/linuxmint/mint-themes/commit/c71c760709fed358c2c4f8010e8dc38a9c1f2d68

https://github.com/linuxmint/mint-themes/issues/298

Sadly, QT applications and the theme engine used in the gtk2 theme don't always seem to place nicely together. If this fix works without breaking the other fix, it should probably be extended to cover notebook entries as well.

schorschii commented 1 year ago

I tested it with the sqlitebrowser and it does not break the other fix.