search

linuxmint / mint-y-icons

The Mint-Y icon theme
123 stars 56 forks source link

RTL icons improvment #306

Closed ronyala closed 2 years ago

ronyala commented 2 years ago

I would like to also invert the direction of the speaker volume icons, however they are missing from mint-y and are loaded from Adwaita. I could copy the ltr version from Adwaita and add an inverted rtl version.

Another issue I found is that the edit-clear icon for recent documents in menu@cinnamon.org applet is not inverted in an rtl layout, despite an rtl icon existing. I'm not sure if that's an icon issue or applet code issue.

mtwebster commented 2 years ago

We're currently in the middle of a major rebase of cinnamon and muffin, and part of this will be support for rtl/ltr icons. Icon theme lookups should automatically search for -rtl-suffixed icons if that's the current text direction. That will probably take care of the edit-clear issue you mention.

I'm not sure about the volume icons, probably it would be fine? I'm just curious why they wouldn't have them if that's a normal 'thing' (assuming Adwaita usually sets the 'standard'). @JosephMcc ?

ref: https://github.com/linuxmint/muffin/pull/601

JosephMcc commented 2 years ago

I honestly don't know the answer to that one. Do level bars switch fill direction in RTL. I guess my question would be, does it make sense to have RTL versions? Since I don't use RTL, we really have to rely on feedback from users who do.

ronyala commented 2 years ago

I personally do believe that the speaker icon (and any similar directional icons) should be inverted when using rtl interfaces, for several reasons:

  1. From a ui perspective in order to properly mirror interfaces that use the speaker icon, it needs a mirrored version. For example, the volume slider in sound@cinnamon.org: תמונה The speaker looks disconnected from the volume slider, instead of the volume 'emanating' from the speaker
  2. The speaker is a directional icon. In english and other ltr languages the speaker sound emanates in the 'natural' direction - to the right, and in rtl languages (and interfaces) it should correspondingly be emanating to the left.

In general, I've found Googles material ui page on rtl interfaces a rather good summary https://material.io/design/usability/bidirectionality.html#mirroring-elements