search

linuxmint / mint-y-icons

The Mint-Y icon theme
123 stars 57 forks source link

[Feature Request] - Add icon to warpinator folder #336

Closed haggen88 closed 1 year ago

haggen88 commented 1 year ago

The warpinator folder is currently identical to the newly created folders. sc

Being a folder that indicates a remarkable place in the system, I think it should have a symbol that distinguishes it.

@SebastJava maybe something like that? warpinator folder

SebastJava commented 1 year ago

Yep. This looks good. This grey #4A4A4A is probably just the right balance between "too much" and "not enough". And it is a good symbol and the size is good, also.

EDIT: Ah, okay, this #4A4A4A is already the standard tint for that anyway. Well, i was just saying it is good, anyway.

This colored stripe could go away, but that's another discussion, as found somewhere else on https://github.com/linuxmint/

haggen88 commented 1 year ago

@SebastJava I only took the symbolic icon, I changed the scale and the color to the ones that appear here, I have no idea of the specific design parameters... I leave it in your hands.

Regarding the stripe, I personally consider that it does not contribute much. It might be more useful to highlight the folder text with a different color... sort of like Elementary does. zzzz

mtwebster commented 1 year ago

There's one problem with this - how do we get file managers or anything else to apply this icon to the correct folder (or any folder the user might configure Warpinator to use)?

This isn't an official XDG-specification folder where there are functions that apps can use to look up their paths and apply the correct icon, so it will be identified as just another folder.

We could do something in Nemo to lookup what the setting is for the save folder and apply the icon to it, but it'll only work in nemo, not file picker dialogs, any other file managers, Cinnamon, etc... so it's probably not worth it.

SebastJava commented 1 year ago

@haggen88 I felt honored to be asked for my feedback on this but I do not have any power here. I do not have a direct access as I am not an official contributor here. My only PRs that got accepted here were just obvious little scripting updates...

@mtwebster I didn't know about that XDG-specification. It sounds serious. This Nemo is already a big complex thing and there are still many bugs to get fixed. So, for sure, I would not even think about adding an extra program or script just for one special icon. Could this Warpinator icon be done the same way as for the downloads and music icons ? If yes, than it's a good idea. Otherwise, please forget it.

haggen88 commented 1 year ago

Could this Warpinator icon be done the same way as for the downloads and music icons ?

@mtwebster I thought it would be something that simple. But apparently it is more complex.