Remove border on maximized windows in metacity

[marcus-lundgren]

The two commits present in this pull request removes the left, right and bottom borders on maximized windows in both of the metacity themes.

They don't look nice, and may introduce UX issues. One example of this is that the user can't merely place the cursor on the left edge of the screen and then initiate a scrolling action. In order to scroll, the user has to move the cursor a few pixel to the right.

[JosephMcc]

Cool, didn't realize the light theme had that border on the maximized windows. You cannot remove the border along the bottom though. It needs to stay at a 1px value. Cinnamon uses the 'max' style for some tiling situations and that border was put there intentionally.

[marcus-lundgren]

Am I correct in that this tiling situation you speak of is when a window is tiled to fill the upper half of the screen? If that's the only place, then wouldn't it be nicer if a specific theming element was introduced instead of reusing max?

I am definitely open to remove the bottom border changes for this PR, and then continue that discussion in another suitable place. Perhaps in an issue?

[JosephMcc]

Am I correct in that this tiling situation you speak of is when a window is tiled to fill the upper half of the screen?

Yes you are. Even if there was a specific style for that I wouldn't want the bottom border removed. Depending on the mix of themes used you end up in situations where there is no border between the bottom of your window and a bottom panel. It also looks strange if you use a dock at the bottom of the monitor instead of a panel.

[marcus-lundgren]

Ah, see what you mean. However, this is supposed to be a borderless theme. Although I can see the merit in a having a bottom border in the use cases you mention, I think that the theme should therefore be borderless throughout. E.g. why should there be a difference in how the theme behave if I were to use a dock and "maximize" the window by manually filling out the screen above, and having it actually be maximized?

[JosephMcc]

However, this is supposed to be a borderless theme.

Not sure who claimed that. I prefer not to have big fat borders but I want a border where I feel they are needed.

[marcus-lundgren]

Not sure who claimed that.

Hmm, I was certain that I had read that Mint-Y was supposed to be a borderless, but I can't find any source to support my claim. But anyways, I will not argue against a very conscious design decision. :-)

I will revert the changes made to the bottom borders, and then make a comment to notify you that it should be ready for another review.

[JosephMcc]

Thanks. I need to do a fix for an issue with xfce which means a new version will get tagged and pushed out soon and I'd like to have your fix for the left and right borders on max windows in the light theme.

Also, after you make your changes in the src/ directory build the theme before you run git commit so that the changes to the the built usr/share/themes/ directories are included as well. Would also appreciate if you squash it all down to a single commit at the end.

[marcus-lundgren]

I've now reverted the changes made to the bottom borders, and also executed the build script that updated the relevant file in user/share/themes. Hopefully I didn't miss anything :-)

[JosephMcc]

The only other thing I'd like to see is these squashed down to a single commit.

[marcus-lundgren]

Ah, sorry. This is my first time contributing using git/github, so am not that familiar with the terminology/workflow. Hopefully I got it right this time!