linuxmint / mint20-beta

BETA Bug Squah Rush
20 stars 8 forks source link

PolicyKit Elevation inconcistencies and translations in various dialogs #67

Closed aureoud-fr85 closed 4 years ago

aureoud-fr85 commented 4 years ago

When a PolicyKit Elevation is required, a French user should see this dialog while "en tant qu'administrateur" is missing: Correcte_PK-Elevation

Instead, with linuxmint-drivers you see this: Gestionnaire_pilotes_wrong_PK User should see in English: "Authentication is required to run %Name of program" as Administrator" or in French: "Une authentification est requise pour exécuter le %Nom du programme en tant qu'administrateur"

This is the same for org.cinnamon.settings-users: Users_Cinnamon_Wrong-PK and for mintsources: Sources-Logiciels-Wrong-PK

An other inconsistencies in Timeshift PolicyKit Elevation: Bug-En-Trans_Timeshift_PK

User should see in French: "Une authentification est requise pour exécuter Timeshift en tant qu'administrateur" instead of English words.

An other inconsistencies in org.x.lightdm-settings: org x lightdm-settings There is no bold text: "Authentication is required to run %Name of program" as Administrator".

VaGNaroK commented 4 years ago

is the same problem for the Brazilian Portuguese language.

clefebvre commented 4 years ago

Yes, this will be the same in all languages.

I don't think "as administrator" is needed. Using the program name as title is done by design, it's there to minimize the need for extra translations, or in the case of timeshift (which clearly shows the issue here), to work around missing translations.

I'd rather see Timeshift there than an English sentence which doesn't bring any additional info. Lightdm-settings needs a title, Users needs a provider. Timeshift needs a workaround or failing that a whole lot of translations it doesn't have.

clefebvre commented 4 years ago

I'll have to check synaptic, it might work in French but only in a few languages.

aureoud-fr85 commented 4 years ago

Hi, @clefebvre, I think you're right. Instead, should we see a PolicyKit Gnome's version like this? Gnome_PolicyKit_Dialog https://blogs.gnome.org/mclasen/2018/12/04/a-policykit-refresher/

A bold title "Authentication required" translatable and a little text. Regards,

aureoud-fr85 commented 4 years ago

Hi, @clefebvre there is another PolKit dialog when launching UFW-gui from system-preferences: PolKit_UFW I think this should be the correct visual interface as it has sufficient and explicitly content.

Moreover, this is the PolicyKit dialog when you want to format USB key or dump ISO file on a USB key: PolKit_USB_Creator

The text in Bold is obvious referring to a python binaries and not the correct action but the dialog came from a correct translated sentence and from upstream component org.freedesktop.policykit.exec.

Regards,

clefebvre commented 4 years ago

mintstick fixed

clefebvre commented 4 years ago

lightdm-settings fixed

clefebvre commented 4 years ago

cinnamon-settings-users fixed in git.

clefebvre commented 4 years ago

timeshift fixed. We're all good.