linuxmint / mint21.2-beta

BETA Bug Squash Rush
9 stars 5 forks source link

Changing size of desktop icons changes size of desktop fonts regardless of font settings #75

Open ghost opened 1 year ago

ghost commented 1 year ago

If I change the size of the desktop icons, the size of the font changes too regardless of my font settings. Is this behavior intentional? Because with the maximum icon size fonts look normal but with every other icon size the font size changes too.

Captura de pantalla de 2023-07-07 17-53-59 Captura de pantalla de 2023-07-07 17-54-17 Captura de pantalla de 2023-07-07 17-54-31

I can still change the font size from the font settings, but the font size I choose isn't what I see in the desktop.

mtwebster commented 1 year ago

The only text size that should be different is the 'Smaller' option, which is deliberate.

It seems ok to me -

Larger icon size vs small vs normal window text. Desktop text size 10, normal text size 10, image

Table for size adjustment in nemo: image

ghost commented 1 year ago

Well, it's been happening to me for a long time in multiple computers and different versions of Mint Cinnamon, so there should be something that's not me causing it. Video_2023-07-08_15-31-04

fredcw commented 1 year ago

Changes for me too. When the desktop font size is set to 13, the font is smaller on "smaller" but also slightly larger on "large" than on "small", "normal" or "larger"

mtwebster commented 1 year ago

What themes are you using (Gtk/Applications)

Also, can you provide dump.txt from:

dconf dump /org/nemo/ > dump.txt
mtwebster commented 1 year ago

Ok sorry my mistake. The desktop overrides those adjustments for SMALL and LARGE - it's actually:

details->font_size_table[NEMO_ZOOM_LEVEL_SMALLER] = -2 * PANGO_SCALE;
details->font_size_table[NEMO_ZOOM_LEVEL_SMALL] =  -1 * PANGO_SCALE;
details->font_size_table[NEMO_ZOOM_LEVEL_STANDARD] = 0 * PANGO_SCALE;
details->font_size_table[NEMO_ZOOM_LEVEL_LARGE] = 1 * PANGO_SCALE;
details->font_size_table[NEMO_ZOOM_LEVEL_LARGER] = 0 * PANGO_SCALE;

Obviously I need to fix 'larger' somehow, but still, to the original question, this is deliberate.

Currently the desktop layout is relatively 'dumb', and text layout takes a back seat to icon spacing. If were to keep the same size all the way to 'small', you'd end up with very short, ellipsized labels. I'd also prefer the label widths adjust depending on the icon spacing, or have the entire icon and label 'item' be a bit more customizable for the user, but it's never been something there was time for.

I can't do anything like this at the moment either, but I can consider tweaks to the adjustments above. Opinions?

ghost commented 1 year ago

I think the icon size setting should change the icon size and respect the user choice of font. I don't understand why it should do anything else except the one thing it's supposed to do.

The users shouldn't have to fight an invisible setting out of their control that undoes their choices. And even if it was visible there would be two settings fighting each other and feeding user wrong information. It doesn't make a lot of sense.

fredcw commented 1 year ago

For the time being I guess, as @Worfwood says, the font size should probably be what the user expects when they set a value in font settings. Nemo icon view is another matter of course.

I'd also prefer the label widths adjust depending on the icon spacing..

I agree, the labels could be wider with wider spacings

or have the entire icon and label 'item' be a bit more customizable for the user,

I think sensible defaults is better than more options. With the desktop spacing for instance, one slider to adjust both horizontal and vertical spacing at the same time would be better, or even just a 3 choice "compact|normal|spacious" setting. (paradox of choice)