search

linuxmint / mintcommon

23 stars 25 forks source link

Additional software dialog is displayed as untranslated #43

Closed AsciiWolf closed 3 years ago

AsciiWolf commented 3 years ago

The "Additional software has to be installed" dialog that is using aptdaemon (at least I think it does) seems to be untranslated on Linux Mint although it is fully translated in my (Czech) language and MintInstall is fully translated as well. See the following screenshot:

additional_flatpak_software_dialog

This happens on a fully updated Linux Mint MATE 20.1 with the following versions of mintinstall/aptdaemon packages installed:

ii  mintinstall      8.0.5                         all          Software Manager
ii  aptdaemon        1.1.1+bzr982-0ubuntu32.3      all          transaction based package management service
xenopeek commented 3 years ago

lbry is a flatpak, those are not installed through APT so aptdeamon has no role here. The dialog you see is created by code from the mint-common package. Moving this issue there.

Here is the text you show is not translated: https://github.com/linuxmint/mintcommon/blob/master/usr/lib/python3/dist-packages/mintcommon/installer/dialogs.py#L78. That is a translatable string. The translation for this looks to have been done: https://translations.launchpad.net/linuxmint/latest/+pots/mint-common/cs/6/+translate.

Same issue if I check this for my language. Edit: no translation files were missing, it's a small bug in the code. Fixed with below PR.

To correct the issue right now you can open a terminal from your menu and run this command:

sudo sed -i "/^APP = 'mintinstall'/c APP = 'mint-common'" /usr/lib/python3/dist-packages/mintcommon/installer/dialogs.py

If you restart mintinstall afterwards it should use translations in the Flatpaks dialog. Here test in Dutch: image

Thanks for reporting the issue!