linuxmint / mintdesktop

Desktop configuration tool for MATE and Xfce
http://www.linuxmint.com
56 stars 25 forks source link

Advice for proper Awesome WM support #15

Closed ernestum closed 7 years ago

ernestum commented 8 years ago

Hi,

I think the possibility to easily change the window manager in XFCE and and MATE is really nice. Therefore I wanted to extend this functionality to the awesome window manager. I made a fork and fixed this (see here for the changes I made).

There are some things which I am not quite happy with yet. Therefore I wanted to ask for your advice before creating a pull request.

  1. awesome does not support the --replace option like the other window managers do. Therefore I need to kill them all before starting a new one (see this line). Maybe that could harm the other window managers? What do you think?
  2. I decreased the sleep delay here because otherwise switching between the window managers takes so long. I feel like there should be a smarter way to wait for all window managers to terminate. I tried subprocess.call instead of Popen but that one did not work.

I am looking forward to you advice!

clefebvre commented 7 years ago

This was merged (implemented by calexil) today.