linuxmint / mintupdate

The Linux Mint Update Manager
309 stars 152 forks source link

When self-update fails/is aborted, upper “Apply updates” button gets active again + ANOTHER ISSUE #790

Open carlosmintfan opened 1 year ago

carlosmintfan commented 1 year ago

Describe the bug When mintUpdate shows: “A new version of the update manager is available”, you click on “Apply the Update” but then cancel, the “Apply updates” button next to the refresh button which isn't active first as we should use the lower “Apply the Update” button - gets active again!

Screenshots first pass then

To Reproduce Steps to reproduce the behavior:

  1. If you already have the latest version of mintupdate and mint-upgrade-info packages so mintupdate doesn't show the self-update screen, do the following:
  2. Open file manage
  3. Go to /var/lib/apt/lists
  4. Right-click an empty area and choose “Open as root”
  5. Open file packages.linuxmint.com_dists_vera_main_binary-amd64_Packages
  6. In Text Editor, search for Package: mintupdate (Look if it's line 1225)
  7. In the next line, replace Version: 5.9.7 with Version: 5.9.8 (replace the 7 with an 8 so APT thinks a new version is available)
  8. Save the file.
  9. Quit update manager from systray (if it's running).
  10. Open it from the menu.
  11. See that upper “Apply updates” button is inactive (as it should, use the lower “Apply the update”button)
  12. Click on “Apply the update”, but then abort.
  13. See that upper “Apply updates” button got active again.

Expected behavior The “Apply the update” button next to the refresh button should stay inactive when a self-update is available, even if it failed/was aborted.

Distribution: Tested in LM 21.1 (Upgraded from 21)

Software version: 5.9.7

Logs: 01.11@18:28 ++ Launching Update Manager 01.11@18:28 ++ Changes to the package cache detected, triggering refresh 01.11@18:28 ++ Starting refresh (local only) 01.11@18:28 ++ Initial refresh will happen in 0 day(s), 0 hour(s) and 10 minute(s) 01.11@18:28 ++ Found 1 software updates 01.11@18:28 ++ Refresh finished 01.11@18:29 ++ Install requested by user 01.11@18:29 ++ Will install mintupdate 01.11@18:29 ++ Ready to launch synaptic Error executing command as another user: Request dismissed 01.11@18:29 ++ Return code:126 01.11@18:29 ++ Install failed 01.11@18:38 ++ Update Manager window is open, skipping initial refresh 01.11@18:38 ++ Recurring refresh will happen in 0 day(s), 0 hour(s) and 48 minute(s)

carlosmintfan commented 1 year ago

+another issue: When clicking refresh, no messages at the bottom left! Please fix together with this.

carlosmintfan commented 1 year ago

No messages at bottom left when clicking refresh at “A new version of the update manager is available” screen. Can you reproduce all this @clefebvre @mtwebster @ everyone interested