linuxmint / mintupdate

The Linux Mint Update Manager
309 stars 152 forks source link

"Apply updates automatically' ignores blacklist and automatically updates all packages anyway (including blacklisted ones) #848

Closed NintendoManiac64 closed 4 months ago

NintendoManiac64 commented 8 months ago

Describe the bug When you have "Apply updates automatically" enabled, it will completely ignore the blacklist and will instead automatically update all packages (including blacklisted ones).

Screenshots How about a video demonstration instead? If you don't want to baby-sit the whole 93 minutes then, when you reach the 5 minute mark, you can skip ahead to exactly the 90-minute mark (or the 91 minute mark if you're fine missing the moment when the updates get automatically installed but before the mouse cursor moves again):

422 10bit @ quality 61.webm

If the video quality is too potato (blame github's 10MB file limit), then you can see a much higher-quality encoding of the very same video over on archive.org:

To Reproduce Steps to reproduce the behavior:

  1. Watch the above video
  2. Boot a live ISO of LMDE 6
  3. Make note of the stock version number for Firefox and/or Thunderbird
  4. Add the packages firefox and firefox* and/or thunderbird and thunderbird* to mintUpdate's blacklist
  5. Enable "Apply updates automatically"
  6. Make sure the PC will not enter S3 suspend
  7. Log out and log back in
  8. Wait a while (take a shower? go buy groceries? make dinner?)
  9. Eventually, updates will be installed automatically and you will find that, despite Firefox and/or Thunderbird being on the blacklist in our example, they will still have been updated.

Expected behavior Packages on the blacklist should not be updated when "Apply updates automatically" is enabled.

Distribution:

Software version: 6.0.5

Additional context I found out about this issue the difficult way on an actual installation of Linux Mint, and then promptly used a live ISO of the newly-released LMDE 6 to verify this behavior (what you see in the above video)

NintendoManiac64 commented 5 months ago

I have just found out that the hold terminal command basically works exactly like mintUpdate's blacklist (even resulting in the given packages not being listed in mintUpdate) except that it also works with automatic updates (though packages that you've applied hold to are not listed in the blacklist):

To be honest, it almost kind of looks like the blacklist is just "reinventing the wheel" but with a worse result compared to the hold command, making me wonder why the blacklist isn't just a GUI front-end for this hold command in the first place...? Heck, the hold command even supports wildcards just like the blacklist does...

NintendoManiac64 commented 4 months ago

It would seem that a function has since been added to mintUpdate on its "Automation" tab that is present in the 21.3 live ISO to export your blacklist to /etc/mintupdate.blacklist in order for automatic updates to actually "see" it, yet this here still-open bug report of mine was never touched nor referenced and so I never even caught wind that this is now a thing... what the heck?

Well I guess I'll just close this issue myself then...

budmanz1 commented 4 months ago

I have no idea of what this is about.

On Fri, Feb 2, 2024, 11:32 PM NintendoManiac64 @.***> wrote:

It would seem that a function got added to "Update Manager" on its "Automation" tab that is even present in the 21.3 live ISO to export your blacklist to /etc/mintupdate.blacklist in order for automatic updates to actually "see" it, yet this here still-open bug report of mine was never touched nor referenced and so I never even caught wind that this is now a thing... what the heck?

Well then I guess I'll just close this issue myself...

— Reply to this email directly, view it on GitHub https://github.com/linuxmint/mintupdate/issues/848#issuecomment-1925129253, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHCKBDHUAGBLHWPZ3IFNPWTYRXDYNAVCNFSM6AAAAAA5XPGGQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVGEZDSMRVGM . You are receiving this because you are subscribed to this thread.Message ID: @.***>