linuxmint / mintupgrade

41 stars 16 forks source link

Failed LMDE 5 to 6 Upgrade due to sticky #79

Closed Den-of-Bees closed 3 months ago

Den-of-Bees commented 7 months ago

Screenshot from 2024-01-25 02-10-33 22

Setting up sticky (1.19) ... File "/usr/lib/sticky/sticky.py", line 765 match method_name: ^ SyntaxError: invalid syntax

Den-of-Bees commented 7 months ago

followed direction, updated and removed foreign packages prior to upgrade attempt

bit-man commented 7 months ago

Happened to me too. Workaround was to comment the whole dbus_method_callback method (lines 764 to 774) and press Check again button

Given that match/case was introduced at Python 3.10 and maybe upgrade tool is using a prior Python version?

jmh79 commented 7 months ago

I encountered this while upgrading LMDE 5 to 6 in VirtualBox. The simplest solution I found was to remove the sticky package before starting the upgrade and re-install it afterwards.

LMDE 5 came with Python 3.9 while LMDE 6 has 3.11. I'm guessing mintupgrade not only decided to upgrade sticky before python3, but also tried to run the new sticky during the upgrade process, causing Python 3.9 to throw the syntax error.

carlosmintfan commented 6 months ago

I added a PR to sticky that may fix this :rocket:

neil-o commented 6 months ago

While awaiting a fix for this bug to be adopted, could there be a warning about it, and a suggested work-around, posted in the Release Notes? https://linuxmint.com/rel_faye.php

The work-around of simply removing sticky before the upgrade, and then reinstalling it after the upgrade, is easy enough for non-expert users to accomplish, but is not likely to be discovered until the attempt to upgrade fails. I believe it would not occur to most users to consult the issue tracker for the minutupgrade package before attempting an upgrade.

carlosmintfan commented 6 months ago

While awaiting a fix for this bug to be adopted, could there be a warning about it, and a suggested work-around, posted in the Release Notes? https://linuxmint.com/rel_faye.php

The work-around of simply removing sticky before the upgrade, and then reinstalling it after the upgrade, is easy enough for non-expert users to accomplish, but is not likely to be discovered until the attempt to upgrade fails. I believe it would not occur to most users to consult the issue tracker for the minutupgrade package before attempting an upgrade.

I don't think so. It's just for the team to get attention to this, if they can add that to the release notes, they can also merge the pull request. It's all in the linuxmint org, sticky too.

lutin11 commented 4 months ago

Also affected by this problem, removing sticky package solve the problem