linuxmint / muffin

The window management library for the Cinnamon desktop (libmuffin) and its sample WM binary (muffin)
GNU General Public License v2.0
196 stars 93 forks source link

Cinnamon crashes when launching applications that start out in full screen mode #592

Closed ME4595 closed 3 years ago

ME4595 commented 3 years ago

Issue When launching applications that start out in full screen, the mouse cursor starts twitching and Cinnamon becomes unresponsive. Depending on the application that was tried to open, the app either crashes and Cinnamon goes into fallback mode and allows me to restart it using the fallback mode message dialogue, or it completely freezes and I have to kill the application I tried to open in TTY. Cinnamon works normally after restarting it from fallback mode or closing the app using TTY.

Steps to reproduce Start an application that starts out in full screen mode

Expected behaviour Cinnamon does not crash and the application starts in full screen.

Other information I have narrowed down the error to this commit 610d60d953cb1bfcc4b6a1aa61997f5d8234a90f, it does not occur when downgrading muffin to a version older than this commit

When running the app starting out in full screen using the terminal, I get the following error message:

X Error of failed request:  BadWindow (invalid Window parameter)
Major opcode of failed request:  40 (X_TranslateCoords)
Resource id in failed request:  0x[some number]
Serial number of failed request: [some number]
Current serial number in output stream: [some number]
mtwebster commented 3 years ago

What program(s)? I can't reproduce this with gnome-terminal or glxgears.

ME4595 commented 3 years ago

I have reproduced the error with the games Muck, Factorio, Kerbal Space Program and Terraria. (The first one is free on Steam, the other ones unfortunately cost money.) I had the error occur both on games from Steam as well as standalone ones, so it is not limited to Steam. All of them work fine when downgrading muffin to the version before the commit I mentioned and start making problems again after updating back to the latest version. I have also tried glxgears on my setup now (and Super Tux Kart), and both work fine for me even using the latest version of muffin.

dknight-bg commented 3 years ago

Same problem Manjaro Stable , muffin 5.0.1-3 Downgrade to muffun 4.8.1 fix issue

Graphics Model: Intel Corporation HD Graphics 620 (rev 02) Driver Module:
i915 2703360 22 i2c_algo_bit 16384 1 i915 drm_kms_helper 270336 1 i915 cec 69632 2 drm_kms_helper,i915 intel_gtt 24576 1 i915 video 53248 1 i915 drm 569344 8 drm_kms_helper,i915

Games : Atom RPG , Divinity: Original Sin , Halcyon 6

mtwebster commented 3 years ago

Hi is this in your normal distro release or are you guys on some sort of daily or testing builds? The offending commit isn't in an 'official' release yet. I would say that unless you are encountering the issue that that commit fixes, you should just run plain 5.0.1

Regardless, I appreciate the beta testing :)

I've reproduced this with Muck, and have a partial fix, but still working on it.

Thanks

ME4595 commented 3 years ago

Hi,

this 5.0.1-3 version is in the official stable branch of the Manjaro repos.

Thanks for helping us!

markusdresch commented 3 years ago

I'm on Cinnamon 5.0.4 (Manjaro DISTRIB_RELEASE=21.1.0, kernel 5.13.1-3) and I have the same issue with any application/game that starts in full screen. i only did official updates, not sure why the 5.0.1-3 is mentioned as official. any way to downgrade apart from timeshift?

v4Lo commented 3 years ago

only did official updates, not sure why the 5.0.1-3 is mentioned as official. any way to downgrade apart from timeshift?

Thanks to this commit https://gitlab.manjaro.org/packages/community/cinnamon/muffin/-/commit/dd226088a2566f989aa39f1386b50ce29457ddcc

Manjaro now builds from master head rather than muffin stable releases. If you don't have the 5.0.1-1 package in cache, so that the tool called downgrade (pacman -S downgrade) works, you can still install asp from aur, then "asp checkout muffin", "makepkg" in the "trunk" folder then "pacman -U" the package file (this uses the arch linux source). Don't upgrade Muffin until Manjaro releases a package that fixes the issue.

It's unfortunate that Manjaro forums point at upstream without looking at what the Manjaro repositories / maintainer did first. The issue with Manjaro Cinnamon including this bug is on them, not on Muffin.

markusdresch commented 3 years ago

thanks a lot. i did try the downgrade route yesterday, but it seemed to only affect the single package without deps resulting in an error when starting cinnamon. will look into asp later, thank you again for the input.

and sorry for interrupting this thread, but wanted to share that the same problem occurs with the version i'm on.

mtwebster commented 3 years ago

Ok I think I've got this fixed now in git master. It actually seems to behave slightly better - muck didn't seem to like my 4k monitor (scaled to 1920x1080) before - it would only show 1/4 of the game window, now it starts out properly.

Please let me know if someone can confirm the fix - I'll re-open the issue if not.

ME4595 commented 3 years ago

Hi, the fix works on my setup. Thank you for solving that issue!

sobrus commented 3 years ago

I've just came across the same problem with Manjaro on my RX570 with Kerbal Space Program and Shadow Of Tomb Raider. Thanks for fixing the issue! I can confirm that downgrading to Muffin 4.8 helps. KSP didn't want to start even in windowed mode, so I'm not sure if this really was only a full screen issue. I didn't manage to build muffin binary from sources yet, so I can't confirm that the fix is working :(

dknight-bg commented 3 years ago

Hi, the fix works on my setup. Thank you for solving that issue!

manjaro/muffin 5.0.1-5 fix the problem
Thanks

Leopard1907 commented 3 years ago

Thanks, this fixed the issue i was having with Red Dead Redemption 2. It never started fullscreen despite it was set to start fullscreen until this update dropped a couple days ago.