linuxmint / muffin

The window management library for the Cinnamon desktop (libmuffin) and its sample WM binary (muffin)
GNU General Public License v2.0
197 stars 93 forks source link

Support zenity >= 3.90.0 or drop zenity #666

Closed bobby285271 closed 1 year ago

bobby285271 commented 1 year ago

Issue

In util.c we use zenity to show dialogs in command-line:

https://github.com/linuxmint/muffin/blob/fc0e48626c553a2ad2588943bb67c2988df6374e/src/core/util.c#L628

With zenity >= 3.90.0 some of the options used are removed/deprecated, and we probably want to get rid of it.

Examples are:

https://github.com/linuxmint/muffin/blob/fc0e48626c553a2ad2588943bb67c2988df6374e/src/core/util.c#L637

--class no longer working: zenity --info --class "mutter-dialog" shows This option is not available. Please see --help for all possible usages.

https://github.com/linuxmint/muffin/blob/fc0e48626c553a2ad2588943bb67c2988df6374e/src/core/util.c#L664

--icon-name deprecated: zenity --info --icon-name "foo" shows Warning: --icon-name is deprecated and will be removed in a future version of zenity; Treating as --icon. (I am using zenity lastest HEAD commit, it is not even working in 3.92.0)

See also

User of meta_show_dialog: https://github.com/search?q=org%3Alinuxmint%20meta_show_dialog&type=code, though I guess most cases are already covered in cinnamon, e.g. cinnamon-display-changes-dialog and cinnamon-close-dialog

Steps to reproduce

N/A

Expected behaviour

N/A

Other information

Nixpkgs unstable, Fedora 38, openSUSE tumbleweed, openBSD currently ships zenity >= 3.90.0 according to repology.


Since e.g. cinnamon-display-changes-dialog is mentioned here, it will be really nice if the solution does not introduce circular dependency since NixOS does not support that yet and we will not able to add cinnamon as a dependency of muffin if that is done :upside_down_face: