linuxmint / nemo-extensions

A set of extensions for Nemo
411 stars 150 forks source link

Invalid CSS values in nemo-preview #189

Closed sergiodlc closed 7 years ago

sergiodlc commented 7 years ago

Nemo-preview crashes on Arch Linux with GTK 3.22.2. This is as a result of invalid values for the font attribute in nemo-preview/data/style/gtk-style.css

According to MDN:

Except when using a keyword, it is mandatory to define the value of both the font-size and the font-family properties.

And here are the offending sections:

GtkSourceView {
    ...
    font: Monospace 10;
}
...
.np-decoration {
    font: bold;
}

Here's the output when running it from the command line:

$ nemo-preview
Cjs-Message: JS WARNING: [/usr/share/nemo-preview/js/ui/mimeHandler.js 61]: assignment to undeclared variable idx
Cjs-Message: JS LOG: Register mimetype application/x-font-ttf
Cjs-Message: JS LOG: Register mimetype application/x-font-otf
Cjs-Message: JS LOG: Register mimetype application/x-font-pcf
Cjs-Message: JS LOG: Register mimetype application/x-font-type1
Cjs-Message: JS LOG: Register mimetype text/plain
Cjs-Message: JS LOG: Register mimetype text/html
Cjs-Message: JS LOG: Register mimetype audio/3gpp
Cjs-Message: JS LOG: Register mimetype audio/ac3
Cjs-Message: JS LOG: Register mimetype audio/AMR
Cjs-Message: JS LOG: Register mimetype audio/AMR-WB
Cjs-Message: JS LOG: Register mimetype audio/basic
Cjs-Message: JS LOG: Register mimetype audio/flac
Cjs-Message: JS LOG: Register mimetype audio/midi
Cjs-Message: JS LOG: Register mimetype audio/mp2
Cjs-Message: JS LOG: Register mimetype audio/mp4
Cjs-Message: JS LOG: Register mimetype audio/mpeg
Cjs-Message: JS LOG: Register mimetype audio/ogg
Cjs-Message: JS LOG: Register mimetype audio/prs.sid
Cjs-Message: JS LOG: Register mimetype audio/vnd.rn-realaudio
Cjs-Message: JS LOG: Register mimetype audio/x-aiff
Cjs-Message: JS LOG: Register mimetype audio/x-ape
Cjs-Message: JS LOG: Register mimetype audio/x-flac
Cjs-Message: JS LOG: Register mimetype audio/x-gsm
Cjs-Message: JS LOG: Register mimetype audio/x-it
Cjs-Message: JS LOG: Register mimetype audio/x-m4a
Cjs-Message: JS LOG: Register mimetype audio/x-matroska
Cjs-Message: JS LOG: Register mimetype audio/x-mod
Cjs-Message: JS LOG: Register mimetype audio/x-mp3
Cjs-Message: JS LOG: Register mimetype audio/x-mpeg
Cjs-Message: JS LOG: Register mimetype audio/x-ms-asf
Cjs-Message: JS LOG: Register mimetype audio/x-ms-asx
Cjs-Message: JS LOG: Register mimetype audio/x-ms-wax
Cjs-Message: JS LOG: Register mimetype audio/x-ms-wma
Cjs-Message: JS LOG: Register mimetype audio/x-musepack
Cjs-Message: JS LOG: Register mimetype audio/x-pn-aiff
Cjs-Message: JS LOG: Register mimetype audio/x-pn-au
Cjs-Message: JS LOG: Register mimetype audio/x-pn-wav
Cjs-Message: JS LOG: Register mimetype audio/x-pn-windows-acm
Cjs-Message: JS LOG: Register mimetype audio/x-realaudio
Cjs-Message: JS LOG: Register mimetype audio/x-real-audio
Cjs-Message: JS LOG: Register mimetype audio/x-s3m
Cjs-Message: JS LOG: Register mimetype audio/x-sbc
Cjs-Message: JS LOG: Register mimetype audio/x-speex
Cjs-Message: JS LOG: Register mimetype audio/x-stm
Cjs-Message: JS LOG: Register mimetype audio/x-tta
Cjs-Message: JS LOG: Register mimetype audio/x-wav
Cjs-Message: JS LOG: Register mimetype audio/x-wavpack
Cjs-Message: JS LOG: Register mimetype audio/x-vorbis
Cjs-Message: JS LOG: Register mimetype audio/x-vorbis+ogg
Cjs-Message: JS LOG: Register mimetype audio/x-xm
Cjs-Message: JS LOG: Register mimetype application/x-flac
Cjs-Message: JS LOG: Register mimetype image/x-gdkpixdata
Cjs-Message: JS LOG: Register mimetype image/png
Cjs-Message: JS LOG: Register mimetype image/x-xpixmap
Cjs-Message: JS LOG: Register mimetype image/x-quicktime
Cjs-Message: JS LOG: Register mimetype image/qtif
Cjs-Message: JS LOG: Register mimetype image/gif
Cjs-Message: JS LOG: Register mimetype application/x-navi-animation
Cjs-Message: JS LOG: Register mimetype image/tiff
Cjs-Message: JS LOG: Register mimetype image/jpeg
Cjs-Message: JS LOG: Register mimetype image/x-tga
Cjs-Message: JS LOG: Register mimetype image/x-portable-anymap
Cjs-Message: JS LOG: Register mimetype image/x-portable-bitmap
Cjs-Message: JS LOG: Register mimetype image/x-portable-graymap
Cjs-Message: JS LOG: Register mimetype image/x-portable-pixmap
Cjs-Message: JS LOG: Register mimetype image/x-icon
Cjs-Message: JS LOG: Register mimetype image/x-ico
Cjs-Message: JS LOG: Register mimetype image/x-win-bitmap
Cjs-Message: JS LOG: Register mimetype image/vnd.microsoft.icon
Cjs-Message: JS LOG: Register mimetype application/ico
Cjs-Message: JS LOG: Register mimetype image/ico
Cjs-Message: JS LOG: Register mimetype image/icon
Cjs-Message: JS LOG: Register mimetype text/ico
Cjs-Message: JS LOG: Register mimetype image/x-icns
Cjs-Message: JS LOG: Register mimetype image/svg+xml
Cjs-Message: JS LOG: Register mimetype image/svg
Cjs-Message: JS LOG: Register mimetype image/svg-xml
Cjs-Message: JS LOG: Register mimetype image/vnd.adobe.svg+xml
Cjs-Message: JS LOG: Register mimetype text/xml-svg
Cjs-Message: JS LOG: Register mimetype image/svg+xml-compressed
Cjs-Message: JS LOG: Register mimetype image/jp2
Cjs-Message: JS LOG: Register mimetype image/jpeg2000
Cjs-Message: JS LOG: Register mimetype image/jpx
Cjs-Message: JS LOG: Register mimetype image/bmp
Cjs-Message: JS LOG: Register mimetype image/x-bmp
Cjs-Message: JS LOG: Register mimetype image/x-MS-bmp
Cjs-Message: JS LOG: Register mimetype image/x-xbitmap
Cjs-Message: JS LOG: Register mimetype image/vnd.djvu
Cjs-Message: JS LOG: Register mimetype image/vnd.djvu+multipage
Cjs-Message: JS LOG: Register mimetype application/x-ext-djv
Cjs-Message: JS LOG: Register mimetype application/x-ext-djvu
Cjs-Message: JS LOG: Register mimetype application/postscript
Cjs-Message: JS LOG: Register mimetype application/x-bzpostscript
Cjs-Message: JS LOG: Register mimetype application/x-gzpostscript
Cjs-Message: JS LOG: Register mimetype image/x-eps
Cjs-Message: JS LOG: Register mimetype image/x-bzeps
Cjs-Message: JS LOG: Register mimetype image/x-gzeps
Cjs-Message: JS LOG: Register mimetype application/x-ext-ps
Cjs-Message: JS LOG: Register mimetype application/x-ext-eps
Cjs-Message: JS LOG: Register mimetype application/pdf
Cjs-Message: JS LOG: Register mimetype application/x-bzpdf
Cjs-Message: JS LOG: Register mimetype application/x-gzpdf
Cjs-Message: JS LOG: Register mimetype application/x-xzpdf
Cjs-Message: JS LOG: Register mimetype application/x-ext-pdf
Cjs-Message: JS LOG: Register mimetype image/tiff
Cjs-Message: JS LOG: Register mimetype application/x-cbr
Cjs-Message: JS LOG: Register mimetype application/x-cbz
Cjs-Message: JS LOG: Register mimetype application/x-cb7
Cjs-Message: JS LOG: Register mimetype application/x-cbt
Cjs-Message: JS LOG: Register mimetype application/x-ext-cbr
Cjs-Message: JS LOG: Register mimetype application/x-ext-cbz
Cjs-Message: JS LOG: Register mimetype application/vnd.comicbook+zip
Cjs-Message: JS LOG: Register mimetype application/x-ext-cb7
Cjs-Message: JS LOG: Register mimetype application/x-ext-cbt
Cjs-Message: JS LOG: Register mimetype application/oxps
Cjs-Message: JS LOG: Register mimetype application/vnd.ms-xpsdocument
Cjs-Message: JS LOG: Register mimetype application/x-dvi
Cjs-Message: JS LOG: Register mimetype application/x-bzdvi
Cjs-Message: JS LOG: Register mimetype application/x-gzdvi
Cjs-Message: JS LOG: Register mimetype application/x-ext-dvi
Cjs-Message: JS LOG: Register mimetype application/vnd.oasis.opendocument.text
Cjs-Message: JS LOG: Register mimetype application/vnd.oasis.opendocument.presentation
Cjs-Message: JS LOG: Register mimetype application/vnd.oasis.opendocument.spreadsheet
Cjs-Message: JS LOG: Register mimetype application/msword
Cjs-Message: JS LOG: Register mimetype application/vnd.ms-excel
Cjs-Message: JS LOG: Register mimetype application/vnd.ms-powerpoint
Cjs-Message: JS LOG: Register mimetype application/rtf
Cjs-Message: JS LOG: Register mimetype application/mxf
Cjs-Message: JS LOG: Register mimetype application/ogg
Cjs-Message: JS LOG: Register mimetype application/ram
Cjs-Message: JS LOG: Register mimetype application/sdp
Cjs-Message: JS LOG: Register mimetype application/vnd.apple.mpegurl
Cjs-Message: JS LOG: Register mimetype application/vnd.ms-wpl
Cjs-Message: JS LOG: Register mimetype application/vnd.rn-realmedia
Cjs-Message: JS LOG: Register mimetype application/x-extension-m4a
Cjs-Message: JS LOG: Register mimetype application/x-extension-mp4
Cjs-Message: JS LOG: Register mimetype application/x-flash-video
Cjs-Message: JS LOG: Register mimetype application/x-matroska
Cjs-Message: JS LOG: Register mimetype application/x-netshow-channel
Cjs-Message: JS LOG: Register mimetype application/x-ogg
Cjs-Message: JS LOG: Register mimetype application/x-quicktimeplayer
Cjs-Message: JS LOG: Register mimetype application/x-shorten
Cjs-Message: JS LOG: Register mimetype image/vnd.rn-realpix
Cjs-Message: JS LOG: Register mimetype image/x-pict
Cjs-Message: JS LOG: Register mimetype misc/ultravox
Cjs-Message: JS LOG: Register mimetype text/x-google-video-pointer
Cjs-Message: JS LOG: Register mimetype video/3gp
Cjs-Message: JS LOG: Register mimetype video/3gpp
Cjs-Message: JS LOG: Register mimetype video/dv
Cjs-Message: JS LOG: Register mimetype video/divx
Cjs-Message: JS LOG: Register mimetype video/fli
Cjs-Message: JS LOG: Register mimetype video/flv
Cjs-Message: JS LOG: Register mimetype video/mp2t
Cjs-Message: JS LOG: Register mimetype video/mp4
Cjs-Message: JS LOG: Register mimetype video/mp4v-es
Cjs-Message: JS LOG: Register mimetype video/mpeg
Cjs-Message: JS LOG: Register mimetype video/msvideo
Cjs-Message: JS LOG: Register mimetype video/ogg
Cjs-Message: JS LOG: Register mimetype video/quicktime
Cjs-Message: JS LOG: Register mimetype video/vivo
Cjs-Message: JS LOG: Register mimetype video/vnd.divx
Cjs-Message: JS LOG: Register mimetype video/vnd.mpegurl
Cjs-Message: JS LOG: Register mimetype video/vnd.rn-realvideo
Cjs-Message: JS LOG: Register mimetype video/vnd.vivo
Cjs-Message: JS LOG: Register mimetype video/webm
Cjs-Message: JS LOG: Register mimetype video/x-anim
Cjs-Message: JS LOG: Register mimetype video/x-avi
Cjs-Message: JS LOG: Register mimetype video/x-flc
Cjs-Message: JS LOG: Register mimetype video/x-fli
Cjs-Message: JS LOG: Register mimetype video/x-flic
Cjs-Message: JS LOG: Register mimetype video/x-flv
Cjs-Message: JS LOG: Register mimetype video/x-m4v
Cjs-Message: JS LOG: Register mimetype video/x-matroska
Cjs-Message: JS LOG: Register mimetype video/x-mpeg
Cjs-Message: JS LOG: Register mimetype video/x-mpeg2
Cjs-Message: JS LOG: Register mimetype video/x-ms-asf
Cjs-Message: JS LOG: Register mimetype video/x-ms-asx
Cjs-Message: JS LOG: Register mimetype video/x-msvideo
Cjs-Message: JS LOG: Register mimetype video/x-ms-wm
Cjs-Message: JS LOG: Register mimetype video/x-ms-wmv
Cjs-Message: JS LOG: Register mimetype video/x-ms-wmx
Cjs-Message: JS LOG: Register mimetype video/x-ms-wvx
Cjs-Message: JS LOG: Register mimetype video/x-nsv
Cjs-Message: JS LOG: Register mimetype video/x-ogm+ogg
Cjs-Message: JS LOG: Register mimetype video/x-theora+ogg
Cjs-Message: JS LOG: Register mimetype video/x-totem-stream
Cjs-Message: JS LOG: Register mimetype audio/x-pn-realaudio
Cjs-Message: JS WARNING: [/usr/share/nemo-preview/js/ui/mainWindow.js 33]: assignment to undeclared variable screen
Cjs-Message: JS WARNING: [/usr/share/nemo-preview/js/ui/mainWindow.js 34]: assignment to undeclared variable mon
Cjs-Message: JS WARNING: [/usr/share/nemo-preview/js/ui/mainWindow.js 35]: assignment to undeclared variable s

(nemo-preview-start:29274): Gtk-WARNING **: Theme parsing error: gtk-style.css:12:12: Not using units is deprecated. Assuming 'px'.

(nemo-preview-start:29274): Gtk-WARNING **: Theme parsing error: gtk-style.css:24:26: The :prelight pseudo-class is deprecated. Use :hover instead.

(nemo-preview-start:29274): Gtk-WARNING **: Theme parsing error: gtk-style.css:25:26: The :prelight pseudo-class is deprecated. Use :hover instead.

(nemo-preview-start:29274): Gtk-WARNING **: Theme parsing error: gtk-style.css:29:26: The :prelight pseudo-class is deprecated. Use :hover instead.

(nemo-preview-start:29274): Gtk-WARNING **: Theme parsing error: gtk-style.css:30:26: The :prelight pseudo-class is deprecated. Use :hover instead.

(nemo-preview-start:29274): Gtk-WARNING **: Theme parsing error: gtk-style.css:48:33: The style property GtkWidget:focus-line-width is deprecated and shouldn't be used anymore. It will be removed in a future version

(nemo-preview-start:29274): Cjs-WARNING **: JS ERROR: Gtk.CssProviderError: gtk-style.css:35:14not a number
Application<._defineStyleAndThemes@/usr/share/nemo-preview/js/ui/application.js:84
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
Application<.vfunc_startup@/usr/share/nemo-preview/js/ui/application.js:70
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
run@/usr/share/nemo-preview/js/ui/main.js:55
@main.c:2
MrElectroNick commented 7 years ago

This seems to be fixed, no?

sergiodlc commented 7 years ago

It is fixed in this repo. Unfortunately, Arch hasn't updated their package yet to include this fix.