linuxmint / nemo

File browser for Cinnamon
GNU General Public License v2.0
1.18k stars 299 forks source link

Adwaita, Nemo highlights file text wrong color #1333

Open dbishai opened 7 years ago

dbishai commented 7 years ago

Right click any file in Nemo using Adwaita as the Controls theme and the text is highlighted with the wrong color giving it a garbled look. This does not occur with the Mint themes.

screenshot from 2016-11-02 22-59-33

leigh123linux commented 7 years ago

Adwaita isn't compatible with nemo and I can't see the gnome devs fixing this.

dbishai commented 7 years ago

Is this not a simple fix in a css file? It just seems odd to ignore it considering it ships with Linux Mint out of the box. Why not fork the theme and keep it alongside the others in linuxmint/cinnamon-themes?

dominichayesferen commented 7 years ago

@dbishai I think it only comes with Mint out-of-the-box mainly due to package dependencies of Adwaita on other GNOME things essential to Cinnamon...

clefebvre commented 7 years ago

Hi, sorry about this

Although @leigh123linux is "right", we need to be pragmatic here and fix stuff that otherwise won't get fixed.

kolorafa commented 7 years ago

I have the exact oposite problem.

When i change filename i don't see the selection:

^ i did select "edoctor"

^ I did select nothing

There is only small "bold" hint what did you select.

dbishai commented 7 years ago

Just wanted to add this also occurs in the address bar of Chrome.

JosephMcc commented 7 years ago

We should probably be including default theming for adwaita in nemo since it is the default theme for gtk3.

cgvirus commented 2 years ago

I was making my favorite theme compatible with nemo. This codes were needed in css

in cinnamon.css:

.expo-workspaces-name-entry,
.expo-workspaces-name-entry#selected {
  height: 1.5em;
  border-radius: 2px;
  font-size: 1em;
  padding: 5px 8px;
  -cinnamon-caption-spacing: 4px;
  color: #c3c3c3;
  background-color: rgba(109, 109, 109, 0.4);
  border: 1px solid rgba(22, 22, 22, 0.4);
  box-shadow: inset 0 2px 4px rgba(0, 0, 0, 0.05); }
  .expo-workspaces-name-entry:focus,
  .expo-workspaces-name-entry#selected:focus {
    border: 1px solid #8f8f8f;
    background-color: #8f8f8f;
    color: #ffffff;
    font-style: italic;
    transition-duration: 300;
    selection-background-color: #ffffff;
    selected-color: #8f8f8f; }

in gtk-3.0/gtk.css

/**
 * Nemo
 */
.nemo-window .primary-toolbar {
  border-bottom: 1px solid rgba(255, 255, 255, 0.12);
}

.nemo-window .primary-toolbar stack > box {
  margin: -2px;
}

.nemo-window .primary-toolbar button.text-button {
  padding-left: 8px;
  padding-right: 8px;
}

.nemo-window .primary-toolbar button:not(.text-button):not(.image-button) {
  padding-left: 4px;
  padding-right: 4px;
}

.nemo-window scrolledwindow.frame {
  border-style: none;
  background-color: transparent;
}

.nemo-window .nemo-window-pane widget.entry {
  border-radius: 4px;
  background-color: rgba(255, 255, 255, 0.04);
}

.nemo-window .nemo-window-pane widget.entry:selected {
  background-color: rgba(138, 180, 248, 0.24);
}