search

linuxmint / nemo

File browser for Cinnamon
GNU General Public License v2.0
1.21k stars 299 forks source link

There is no row/item highlight indicator anymore #460

Closed Redsandro closed 7 years ago

Redsandro commented 10 years ago

In most file managers, you have 3 states for items:

  1. Nothing.
  2. Highlighted.
  3. Selected.

There is no visual highlight state anymore. Only nothing or selected. When you move with the keyboard cursor, the highlighted item will automatically be selected, so you know where your 'cursor' is at.

But when making a selection using your keyboard cursor keys, holding CTRL, and using SPACE to select/unselect files, there is no visual hint as to where your cursor is anymore. Making it hard to do this when you skip a bunch of files before selecting a new one.

anandrkris commented 10 years ago

Icons do get highlighted in Icon and Compact view. Although, nothing in List view. Perhaps delibertely done so keeping in mind performance overheads?

Redsandro commented 10 years ago

I don't think it's a performance thing. It's probably a developers-forgot-to-implement-this-because-they-don't-use-the-keyboard thing. On Aug 7, 2014 6:24 PM, "Anand" notifications@github.com wrote:

Icons do get highlighted in Icon and Compact view. Although, nothing in List view. Perhaps delibertely done so keeping in mind performance overheads?

— Reply to this email directly or view it on GitHub https://github.com/linuxmint/nemo/issues/460#issuecomment-51495648.

mtwebster commented 10 years ago

It can be fixed in the theme - support is already there, most themes apparently don't care to style hovered GtkTreeView rows.

Vahan86 commented 7 years ago

Icons do get highlighted with dash lines in all 3 views (Icon, List and Compact) in Mint-Y theme, though the issue is still reproducible when theme is set to Mint-X for example.

@JosephMcc, can we close the issue since it is related to themes.

JosephMcc commented 7 years ago

This is a theme issue. In Mint-X they were removed intentionally.

Redsandro commented 7 years ago

@JosephMcc it feels though as if it was done intentionally by mistake, and I'm not sure if 'done intentionally' is a good reason for closing this issue.

By mistake I mean that the theme developer (clearly?) never used keyboard multi-selection and thought: What is this border style for? I've never seen it in action. No one uses this. I might as well remove it.

Similarly, if I never use a mouse, I could decide to make a theme without a mouse cursor. Intentionally. That doesn't mean that it's a good design, or that we can't have a discussion about bringing the mouse cursor back because it's a default theme for an operating system on a computer that commonly has a mouse attached.

JosephMcc commented 7 years ago

it feels though as if it was done intentionally by mistake, and I'm not sure if 'done intentionally' is a good reason for closing this issue.

Maybe, but the fact that it isn't an issue with Nemo is a perfect reason to close it.

By mistake I mean that the theme developer (clearly?) never used keyboard multi-selection and thought: What is this border style for? I've never seen it in action. No one uses this. I might as well remove it.

Sure. That's how it happened. I learned a long time ago that no matter what decisions you make to something design wise, some people will hate it. It's the nature of the beast. Switch to a different theme. Problem solved.

anandrkris commented 7 years ago

@Redsandro - Please don't assume any intentions when we can ask? @JosephMcc - Happy to raise a request under themes. Could you please share rationale for inconsistency in List view alone?

JosephMcc commented 7 years ago

@anandrkris Just for general info, this isn't going to be changed in Mint-X. The focus indicator in question here when keyboard navigating isn't visible in any view.

Redsandro commented 7 years ago

@anandrkris

Please don't assume any intentions when we can ask?

My apologies for sounding omnipotent. :wink: I merely intended to propose that closing an UX issue on the grounds that it was intentional is not logical reasoning.

Logic is the study of the principles of reasoning. As a form of science, logic is used to solve various problems through the application of deductive reasoning.

That said, I won't be continuing my argument. Before there was Mint-Y, I found the necessity to use custom themes in order to get basic UX a bad logical choice for Linux Mint. Luckily there's Mint-Y now, and I like the theme, so for me personally it's not a problem any more. :+1:

Note that this issue is from 2013.

anandrkris commented 7 years ago

I think what I'm seeing is another issue specific to List View. I will try to capture a small video - essentially no indication on hover in List View.

JosephMcc commented 7 years ago

Are you talking about the icon highlighting on mouse over?

anandrkris commented 7 years ago

Yes.

And sorry, I misunderstood this with keyboard navigation / selection.