linuxmint / nemo

File browser for Cinnamon
GNU General Public License v2.0
1.2k stars 299 forks source link

Nemo has some big ugly icons #768

Closed geckolinux closed 8 years ago

geckolinux commented 9 years ago

Hi there,

I'm working on getting Cinnamon in good shape for openSUSE. For some reason, on both Nemo 2.2 and Nemo 2.4 without any special distro-specific patches, some icons are huge and ugly. Specifically they are "Toggle location entry", "Show places", "Show treeview", and "Hide the sidebar". These icons do not change, and appear to be independent of the main system icon theme that is selected. I'm attaching a screenshot. Any suggestions on why this is happening or what can be done to fix it?

Thanks a lot!

screen1

leigh123linux commented 9 years ago

Are you using gtk-3.14? (if so which version).

linuxrecon commented 9 years ago

I'm working together with sb56637 on the openSUSE Cinnamon builds.

The GTK Version used in openSUSE 13.2 (the version which is affected by this problem) is actually 3.14.4.

leigh123linux commented 9 years ago

Try using a gtk-3.14 compatible theme for controls (adwaita isn't good).

nemo is fine here using zukitwo (from link below) with gtk-3.14.5

http://lassekongo83.deviantart.com/art/Zukitwo-203936861

linuxrecon commented 9 years ago

For me, the problem still exists with the ZukiTwo theme.

Also, I'm already using Mint-X for WM Border and Control before.

leigh123linux commented 9 years ago

Mint-X doesn't support gtk-3.14 yet

https://github.com/linuxmint/mint-themes-gtk3/pull/38

linuxrecon commented 9 years ago

Ok, so I installed ZukiTwo theme, set the theme with gesettings (as recommended in the INSTALL file) and with the cinnamon-control-center. This is how it looks like: err

geckolinux commented 9 years ago

Yes, I have also been using Zukitwo. My first screenshot was from a new install on a different machine. But those particular buttons don't change, regardless of the controls or icon theme used.

By any chance is something in the code making it pull in high-contrast icons for those buttons? That's what they look like to me.

leigh123linux commented 9 years ago

The remaining oversized icons are provided by nemo

/usr/share/icons/hicolor/scalable/actions/location-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/sidebar-hide-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/sidebar-places-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/sidebar-show-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/sidebar-tree-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/view-compact-symbolic.svg
geckolinux commented 9 years ago

Hmm, I see that they are SVG icons. So is there something in the Nemo code that determines the size/scale of those icons? And how are they different from the other icons (home, search, etc.)?

JosephMcc commented 9 years ago

I run Cinnamon in Debian Jessie which is also on Gtk3.14. I don't have the issue you're showing there. One difference however is that I'm running the newest released version of Cinnamon/Nemo which is 2.4 and you are on an older version. Maybe try the current version if possible and see if the issue still exists.

geckolinux commented 9 years ago

Hi JosephMcc, thanks for the comment. Actually I am also running the newest released version of Cinnamon and Nemo on one system, and this issue still exists.

mountainerd commented 9 years ago

Just to add another comment to the thread here, I am also on openSUSE and having the same issue with giant icons on some themes, running current gtk version and current Cinnamon versions.

ManIVIctorious commented 9 years ago

it is also a problem on arch, the most annoying one is the giant trash icon when using linux mint icon theme: Commercial Photography

JosephMcc commented 9 years ago

@ManIVIctorious the last one with the over sized trash icon isn't a nemo issue. It's an issue with the Mint-X icon theme. It needs some updating to work properly with gtk3.14

ManIVIctorious commented 9 years ago

@JosephMcc : just one question, how can a icon-theme, which merely consists of icons (png, svg and xpm) be incompatible to a gtk-version?

JosephMcc commented 9 years ago

@ManIVIctorious : because gtk uses the info layed out within the index.theme supplied by the icon theme to go about finding the appropriate icon at the correct size. Before 3.14 the info given in the index.theme was pretty loosely adhered to and it's now much stricter.

For the trash icon, say we only include it in the theme at the 48px size. Then in the index.theme say it can only be scaled within a range of 32px-64px. When gtk looks up the icon it will only use it at the sizes we allow. Previous to 3.14 it would just grab it and scale it to the size it wanted regardless.

leigh123linux commented 9 years ago

LOL

nautilus also has icons issues

https://bugzilla.redhat.com/show_bug.cgi?id=1178950

leigh123linux commented 9 years ago

The menu icon issue is fixed in the gtk-3.14.8 release and the statusbar in nemo-2.4.5

https://github.com/linuxmint/nemo/commit/be559c3402fa4e4768a6abbe585e29e963603c15

JosephMcc commented 9 years ago

Actually I'm not sure that statusbar fix is going to help anything here. The problem looks to be caused by the icons themselves. What confuses me is why only openSUSE seems to be having that particular issue.

ghost commented 9 years ago

I found a fix for both the toolbar and status bar. Here's how to do it:

1) Open /usr/share/icons/hicolor/index.theme 2) Search for scalable/actions 3) just below the line paste this instead of the default block:

MinSize=10
Size=16
MaxSize=16
Context=Actions
Type=Fixed

4) Just change the icon theme to any to force reload

The result is as follows:

screenshot from 2015-02-20 22 23 00

XRevan86 commented 8 years ago

Fixed in openSUSE.