linuxmint / slick-greeter

A slick-looking LightDM greeter
GNU General Public License v3.0
353 stars 58 forks source link

tap-to-click is force-enabled system wide when using slick-greeter #220

Open 0xDEADCADE opened 1 year ago

0xDEADCADE commented 1 year ago
 * slick-greeter 1.8.0
 * Arch
 * NVIDIA GeForce RTX 2060 Mobile - NVIDIA 530.41.03
 * 64 bit

Issue Since the latest release, tap-to-click gets force-enabled on every connected touchpad when starting slick-greeter. The Xorg or libinput config is not checked, and the default "off" behavior of libinput is also not respected.

Libinput provides two reasons for why the default behavior should be off: https://wayland.freedesktop.org/libinput/doc/latest/tapping.html#tap-to-click-default-setting

Steps to reproduce Install and enable slick-greeter with tap-to-click explicitly disabled in xorg/libinput touchpad config. Tap-to-click will be enabled as soon as slick-greeter starts.

Expected behaviour Slick-greeter should respect the user and distro xorg/libinput config and not override them system-wide.

auriusbendikas commented 1 year ago

I have wasted so much time of my life trying to figure out why suddenly after updates tap-to-cick got enabled even after I have logged in. I had to write a script to disable it after every login.

Thank god this behavior was logged in syslog and I have found this issue report.

So I have checked source code this behavior was introduced with fix for #112. And it can not be disabled with configuration.

I understand that it is fix for #112 however this behavior must be either configurable, or reset to defaults after greeter is done. It should not force tap-to-cick to be forcefully enabled for logged in sessions.

Especially since #112 feels more like workaround for misbehaving/misconfigured hardware rather than a fix for a bug in slick-greeter.

Now the fastest way to disable this behavior is to delete /usr/bin/slick-greeter-enable-tap-to-click. However it will be back after slick-greeter update.

tarwirdur commented 9 months ago

I lost almost two hours trying to understand why I can’t disable tap-to-click.

Thank god this behavior was logged in syslog and I have found this issue report.

+1! And thanks for the clear file names!