linuxmint / timeshift

System restore tool for Linux. Creates filesystem snapshots using rsync+hardlinks, or BTRFS snapshots. Supports scheduled snapshots, multiple backup levels, and exclude filters. Snapshots can be restored while system is running or from Live CD/USB.
2.39k stars 86 forks source link

Un-tagged snapshot list displays wrong name #223

Open woodward2 opened 1 year ago

woodward2 commented 1 year ago

Describe the bug When timeshift takes a backup which results in more than one excess snapshot, the list of snapshots to be un-tagged consists of the first item repeated rather than each item (although the excess snapshots are subsequently deleted correctly).

To Reproduce Run a backup that creates more than one excess snapshots.

Expected behavior The list of snapshots being un-tagged should correctly reflect what is actually being done.

Screenshots

Timeshift v22.06.5 by Tony George (teejeetech@gmail.com)

Mounted '/dev/sdc5' at '/run/timeshift/1089766/backup'
------------------------------------------------------------------------------
Creating new snapshot...(RSYNC)
Saving to device: /dev/sdc5, mounted at path: /run/timeshift/1089766/backup
Linking from snapshot: 2023-07-31_01-02-21
Syncing files with rsync...
RSYNC Snapshot saved successfully (143s)
Tagged snapshot '2023-08-07_01-11-59': ondemand
------------------------------------------------------------------------------
Maximum backups exceeded for backup level 'weekly'
Snapshot '2023-07-03_01-18-19' un-tagged 'weekly'
Snapshot '2023-07-03_01-18-19' un-tagged 'weekly'
Removing snapshots (un-tagged):
------------------------------------------------------------------------------
Removing '2023-07-03_01-18-19'...
------------------------------------------------------------------------------
------------------------------------------------------------------------------
Removing '2023-07-10_01-10-27'...
------------------------------------------------------------------------------

Found stale mount for device '/dev/sdc5' at path '/run/timeshift/1089766/backup'
Unmounted successfully

System: Linux Mint 20.3 Una MATE: 1.26.0 Timeshift v22.06.5