linuxmint / timeshift

System restore tool for Linux. Creates filesystem snapshots using rsync+hardlinks, or BTRFS snapshots. Supports scheduled snapshots, multiple backup levels, and exclude filters. Snapshots can be restored while system is running or from Live CD/USB.
2.39k stars 86 forks source link

Documentation unclear regarding Docker #255

Open ejohb opened 9 months ago

ejohb commented 9 months ago

Hi all,

I've just seen in the README that "Docker and containerized systems are not supported. Running Timeshift on such systems will have unpredictable results."

However, I've been using Timeshift on a Docker host seemingly without issue (yes, I've actually applied restore points in practice) because I was unaware of any issue. Since everything has been working for me, is this issue still even relevant?

If so, I'd like to suggest the following:

sskras commented 8 months ago

I guess the original statement warns about dealing with /var/lib/docker directory on the host: https://stackoverflow.com/questions/76280433/how-to-get-docker-to-read-var-lib-docker-correctly

If docker is stopped, my guess is that reading the directory is going to avoid corruption of logical structure in the data files, which otherwise changes so quickly that even FS snapshots doesn't guarantee consistent state of the files: https://community.sisense.com/t5/knowledge/relocating-var-lib-docker-directory/ta-p/18596

mkindred commented 7 months ago

My limited understanding is that docker (host) uses bind mount points, which fools (fooled) timeshift into changing its snapshots directory. It seems that this was mitigated back in 2018 in the previous repository, but I haven't tried it for myself.

It does look as though that commit is in this repository.

I agree that the README should be updated and clarified.