linuxmint / ubiquity

Installer
https://www.linuxmint.com
46 stars 48 forks source link

Installer window cannot be resized #64

Open avidseeker opened 1 year ago

avidseeker commented 1 year ago

Trying out latest Linux Mint iso, and when the partitioning step came up, I tried resizing the window for the installer but it's not possible.

Tried every way possible: Meta + mouse drag, double clicking window drag area, right clicking window title then Maximize. They all don't work.

Please add the ability to resize/maximize the installer window. This would help small screens.

DirkHaar commented 7 months ago

I discussed that and tried to get rid of that problem but Joseph doesn't like my solution. Additionally to the horizontal space, I find it highly dangerous you only see 4 partitions at once.

My personal workaround:

JosephMcc commented 7 months ago

I didn't remember anything about this and when I went looking back this is what I could find: https://github.com/linuxmint/ubiquity/pull/50

While it wasn't me, those do seem like very legitimate reasons.

DirkHaar commented 7 months ago

I must apologize, you#re right, it was mtwebster. Though I still do not understand what's the problem here because noone who doesn't need to resize the dialog would do, and I don't find any "ugly" effects on the not very important dia show (compared to "overview where to install and which partitions to manipulate"). (If someone could tell me where in the code(s) to take back the "resizable", it would be fine to change it, right?)

I gave it up and use my temporary workaround described above.

freckhard commented 1 month ago

Hallo @DirkHaar, thanks a lot for your working workaround! ✅

* start the installer
* cancel it
* open a terminal and use "sudo xed /usr/lib/ubiquty/ubiquity/frontend/gtk_ui.py
* around line 952 you find "self.live_installer.set_resizable(FALSE)
* replace FALSE by 1
* save & exit the file
* restart the installer.

This is/was driving me crazy, especially using the edge iso defaulting in my live medium to 4k resolution and then only have been able to see 3 tiny rows at the same time. I have 5 disks with 3-4 partitions each in my machine, so this was a scrolling nightmare!

So dear devs, this is still a thing, please reconsider!

DirkHaar commented 1 month ago

Glad it's helpful!

I'll have a deeper look at the code so I can fix that according to the consideration to reset the dialogue size after completing the partitioning. I'm not fit in python (SAS and COBOL and much more, but not C, Java, JavaScript, Python).