I believe I've found a very minor bug in server.py that causes a 'sending' transfer from a client machine to fail on retry.
(I am using version 1.2.4, but as far as I checked this has not been addressed in any commits since)
for existing_op in remote_machine.transfer_ops:
if existing_op.start_time == request.info.timestamp:
# Compression could have changed for a restart, as it's not tied to the op.
try:
op.use_compression = request.info.use_compression
except AttributeError:
op.use_compression = False
existing_op.set_status(OpStatus.WAITING_PERMISSION)
self.add_receive_op_to_remote_machine(existing_op)
return void
op.use_compression = request.info.use_compression
and
op.use_compression = False
should be:
existing_op.use_compression = request.info.use_compression
and
existing_op.use_compression = False
Hello!
I believe I've found a very minor bug in server.py that causes a 'sending' transfer from a client machine to fail on retry. (I am using version 1.2.4, but as far as I checked this has not been addressed in any commits since)
I tried restarting a transfer from the Warpinator Android app ([https://github.com/slowscript/warpinator-android]), which failed. Debug mode on the computer revealed:
The transfer restart worked as expected when the changes below were made to my local 'server.py' source file.
Within the 'try' statement in the for-loop at 457: https://github.com/linuxmint/warpinator/blob/01e2e1d0a1eac75b70d5990fd4a0cdc4d99af932/src/server.py#L457
op.use_compression = request.info.use_compression
andop.use_compression = False
should be:
existing_op.use_compression = request.info.use_compression
andexisting_op.use_compression = False
to match the for-loop declaration.
Hope this is helpful!