Open AndreiMiculita opened 1 year ago
This should be prevented by default on Linux (the receiving machine must have this enabled).:
What are all the devices involved? I don't know the status of this functionality in the non-Linux versions.
Using Warpinator 1.2.9 on Linux Mint 20.3
Using (slowscript) Warpinator 1.4.6 on Android 10
The transfer is from the mobile client to the desktop client. The settings on the desktop client look as follows:
Note that after initiating the transfer from the mobile client, the regular notification for the file transfer does show up on desktop. But there is no notice of another file with the same name existing or being overwritten.
This is a screenshot of the transfer history, note how the two files have different sizes:
And here you can see there is only one file in the directory:
This works for me between two PCs:
There is no indicator of files being overwritten in the notification, but it should show this in the window.
We could definitely improve the notification to have a bit more info like this, especially since the non-flatpak version has buttons in the notification to allow the transfer to be started without opening the window.
Ah, I found this warning. Way too easy to overlook in my opinion. It's also not visible from the home screen of the desktop client, it requires that you actually open the page of the device you're receiving from. I'm referring to this:
And again, yes, it doesn't show up at all in the notification (I'm using the non-flatpak version).
There should be a separate pop-up after accepting the transfer, with the same options that Nemo provides (overwrite or rename the file to resolve the conflict).
Edited title to point out the most straightforward solution. A popup for conflict resolution (rename/overwrite) would be nice to have but not essential for now.
Uploading a new file with the same name (e.g. from the mobile client) as an older one results in the old file being overwritten on the PC.
This happens, for example, when I generate an invoice file from my banking app. The file is always generated with the same name and the share popup shows immediately. I select Warpinator, then I select my laptop, and when the transfer happens, there is no warning, no popup, the file just gets sent and the old one is lost forever.
Edit: the file approval popup does pop up as usual, it just doesn't mention anything about duplication or overwriting.