linuxmint / warpinator

Share files across the LAN
GNU General Public License v3.0
1.17k stars 80 forks source link

Bug found in code - parameter name incorrect #153

Closed fenilgmehta closed 1 year ago

fenilgmehta commented 1 year ago

Check this line - https://github.com/linuxmint/warpinator/blob/1773127d1f7fd5fca20610ed655df104e25177a4/src/transfers.py#L224 It should be fatal instead of fatel

fenilgmehta commented 1 year ago

I think PyCharm should be used for development as it automatically detects such issues, and provides many more features.

mtwebster commented 1 year ago

Thanks.

We use a number of different languages, not just python, so a more generalized editor is preferred (I've used sublime for a long time).

Also, the couple of times I tried something like PyCharm, it wasn't very useful due to how we use python in most of our software - most 'modules' are not actually python modules but C libraries with language bindings for python, or some other language - if I recall, they didn't really know what to do with this stuff. Maybe this has changed more recently, but I still don't want to use multiple editors for different languages.

fenilgmehta commented 1 year ago

Hm. Just a question out of curiosity, which project/repository do you or your team spend maximum time working on ?