linuxmint / warpinator

Share files across the LAN
GNU General Public License v3.0
1.21k stars 81 forks source link

add a toggle switch for Secure Mode #171

Closed niwla23 closed 1 year ago

niwla23 commented 1 year ago

Today I saw that warpinator now asks me to setup a group code. If I understand correctly, this will not allow me to share with people using another code. While I can see that you don't want to be spammed with files in public wifis (or what are the problems with having it in insecure mode?) I also think that it limits the usability as you can't quickly send a file to someone else (kina like airdop)

So why not add a little toggle in the top bar to enable Insecure Mode (maybe rename it to Public Mode then)? Otherwise you would have to go to settings, back up your group code, change it to "Warpinator", send the file and change it back to your original group code.

mtwebster commented 1 year ago

Nothing has really changed here - you've already got a group code - "Warpinator". All we're after here is to get people to change it to something else as soon as they can. If you have three computers on your network you like to send files between, just come up with a new code, and change those three machines to use it. That's it, you never have to change anything else.

Consider:

If you have a unique group code among your computers, this scenario can't happen, since their group code is 'Warpinator' and yours aren't. They're blind your machines.

This is all we're trying to accomplish here. It's the same reasoning as not keeping some 'default' password on a router or some other device - anyone can figure it out by googling 'default netscreen router password'.

You can still use warpinator with the default code, but it puts limitations on it to keep unsafe things from happening, like not allowing approvals to be disabled and preventing Warpinator from autostarting.

niwla23 commented 1 year ago

You can still use warpinator with the default code, but it puts limitations on it to keep unsafe things from happening, like not allowing approvals to be disabled and preventing Warpinator from autostarting.

This is what I meant the toggle for. The toggle would internally just save the current code and then use "Warpinator" instead while being on. After switching it off again it would use the old, manually configured code again. This would enable you to easily share files with guests in your wifi if both simply enable the public sharing mode.