search

linuxmint / warpinator

Share files across the LAN
GNU General Public License v3.0
1.24k stars 83 forks source link

Sending Camera folder to PC erases existing folder on PC #205

Open tonywhelan opened 10 months ago

tonywhelan commented 10 months ago

History: refer https://forums.linuxmint.com/viewtopic.php?p=2424201#p2424201

My new PC has Mint 21.3 Cinnamon, Warpinator v1.8.3
My Android phone has warpinator v1.7

Sending the folder "Camera" from my Android phone works. If I delete those files from the phone, take some more pics, then use warpinator to send the Camera folder to the PC, it wipes out the files that had previously been transferred to the PC.

"Require approval when files would be overwritten" is off. But it isn't overwriting files of same name, it is erasing existing files with different names.

I would expect the program to copy the new files into the target folder without deleting existing files

CaptainSalami commented 9 months ago

I have the exact same problem.

carlosmintfan commented 5 months ago

So warpinator should check whether the file to overwrite is a folder and if it is, just add the new files into it. However, can you thik of any situation where the user would expect the existing folder to be overwritten?

yumpyy commented 4 months ago

https://github.com/linuxmint/warpinator/blob/34413b665559c96f8ccc4bff5856d180e02777f6/src/transfers.py#L189C1-L193C35 looks like this blob is responsible for overwriting folders/files with same names.

carlosmintfan commented 4 months ago

@mtwebster wants it to be like that so you don't accidentally get some files in an existing folder with applications or so...but it should be clarified in the settings to "overwrite files and folders"