Feature request: Tray icon changing situation-dependent

linuxmint / warpinator

Share files across the LAN

GNU General Public License v3.0

1.2k stars 81 forks source link

Feature request: Tray icon changing situation-dependent #50

Open Mintulix opened 4 years ago

Mintulix commented 4 years ago

Warpinator 1.0.6 LM 20 Cinnamon

Icon stays always the same. It could change depending on some situations, especially these two:

at least one connection to another Warpinator successfully established
a new recieve-request is coming in (notification is atm only displayed for the first request, not for further ones - without opening Warpinator no one would know...)

mtwebster commented 4 years ago

Thanks for bringing this up - #49 is caused by the simple fact we forgot to make an 'offline' icon, though we did code one, which is why you get a blank.

https://github.com/linuxmint/warpinator/blob/master/src/warpinator.py#L1220-L1225

I agree there should be at least one more additional state (incoming request) as well.

mtwebster commented 3 years ago

Offline/error state addressed by https://github.com/linuxmint/warpinator/commit/89668b2294b82e449887765f482f6963d75fd365

I leave this open to consider an 'incoming' state.