Put IP address into correct field on the certificate

linuxmint / warpinator

Share files across the LAN

GNU General Public License v3.0

1.21k stars 81 forks source link

Put IP address into correct field on the certificate #70

Closed slowscript closed 3 years ago

slowscript commented 3 years ago

IP should be put into "IPAddress" subject alternative name, not "DNSName". Some implementations of TLS (like Conscrypt) reject the certificate otherwise. I have tested this with older versions and it didn't break compatibility.

mtwebster commented 3 years ago

Weird I'm not sure why I didn't see this when I was working out how to avoid needing a dns name.

Thanks