linuxmint / warpinator

Share files across the LAN
GNU General Public License v3.0
1.18k stars 80 forks source link

Preserve date #93

Closed vgstef closed 2 years ago

vgstef commented 3 years ago

When transferring documents, is it possible to add an option to preserve the date.

Especially when transferring many files at the same time (ex. pictures), it gets hard to sort the transferred files when all get the date of the transfer.

RockettheGoat commented 2 years ago

Hi, I'm looking to solve this particular problem too, any help welcomed

xenopeek commented 2 years ago

@RockettheGoat this is a enhancement request so it's not possible currently with Warpinator. As a kind of workaround put the file you want to transfer in an archive (.tar.gz or similar) first, transfer that and unarchive it on the other side which preserves file dates.

RockettheGoat commented 2 years ago

Thank you Vincent, that work around is a great help.

Cheers

On Fri, 13 Aug 2021 at 22:11, Vincent Vermeulen @.***> wrote:

@RockettheGoat https://github.com/RockettheGoat this is a enhancement request so it's not possible currently with Warpinator. As a kind of workaround put the file you want to transfer in an archive (.tar.gz or similar) first, transfer that and unarchive it on the other side which preserves file dates.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/linuxmint/warpinator/issues/93#issuecomment-898349228, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVGDRXDSK3JRGXMLFKJMXG3T4TVTPANCNFSM47CDVSDA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

vgstef commented 2 years ago

@xenopeek Thanks for the idea. It's a nice workaround, but not practical when I send pictures from my phone to my laptop.

mtwebster commented 2 years ago

Fixed by: https://github.com/linuxmint/warpinator/commit/e9a14b53572dc8198a57d45b79a60440362de055

RockettheGoat commented 2 years ago

Thanks!

On Fri, 27 Aug 2021 at 02:27, Michael Webster @.***> wrote:

Fixed by: e9a14b5 https://github.com/linuxmint/warpinator/commit/e9a14b53572dc8198a57d45b79a60440362de055

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/linuxmint/warpinator/issues/93#issuecomment-906462194, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVGDRXFPUELHNVMBCDD27FDT6ZFLRANCNFSM47CDVSDA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

STPKITT commented 2 years ago

I just tested this on a machine running up-to-date KDE neon User edition where I installed Warpinator via Flatpak after suffering from this issue for nearly 6 years using the file transfer feature of KDE connect. I filed a bug report in 2016 but it still isn't fixed in KDE connect. The smartphone I used had the Warpinator app installed which is offered on F-Droid and the smartphone runs LineageOS 16.0 aka Android 9.

My test result is the following:

Sending a file from PC to smartphone: the file modification timestamp of the target file gets changed to the moment of the transfer.

Sending a file from smartphone to PC: the file modification timestamp of the target file is the same as the source file which is the desired result.

So unless I missed something in regards to the timeliness of the Warpinator Flatpak package or if the Android app is the guilty one I'd say this bug isn't fully solved yet which means this issue would need to be reopened.

mtwebster commented 2 years ago

I'm not sure what's happening here. I just tried from pc to pc (both on 1.2.9 - latest - flatpak) and it worked as expected. I wonder if the mobile app is having trouble re-setting the mtime on received files.

I try to keep the flatpak reasonably up-to-date, but it usually lags behind normal updates a bit. I'm going to bring up to current soon, but I ran into some packaging issues in Mint/Ubuntu, which made me rethink how I bundle things for the flatpak, so I need to work on it bit.

STPKITT commented 2 years ago

Thanks very much for your answer and trying it out again! Since it seems that the Android app plays a role in the issue I found I just opened a corresponding issue on that app's issue tracker: https://github.com/slowscript/warpinator-android/issues/111.