search

linuxmint / webapp-manager

GNU General Public License v3.0
705 stars 93 forks source link

Falkon parameters are wrong #294

Open Cris70 opened 6 months ago

Cris70 commented 6 months ago

When creating a web app with Falkon, webapp-manager build the desktop file using non-existent parameters (maybe they worked in an older release of Falkon, I don't know). The result is that Falkon starts with the default profile and does not open the given URL .

This is the command line that is created by webapp-manager: falkon --app=https://xxx.xxx.xxx.xxx/ --class=WebApp-NAME_AMENDED --name=WebApp-NAME_AMENDED --user-data-dir=/home/cris/.local/share/ice/profiles/NAME_AMENDED

This is what instead works with recent releases of Falkon: falkon --wmclass WebApp-NAME_AMENDED --profile=NAME_AMENDED --no-remote https://xxx.xxx.xxx.xxx/

Note that the profile will not be created in /home/$USER/.local/share/ice/profiles/, but in /home/$USER/.config/falkon/profiles/.

I am using Falkon 24.02.2 from KDE6 on linux openSUSE Tumbleweed.

Judging from ticket #188 the parameters were already different in KDE5.

Cris70 commented 6 months ago

Just finished creating PR #295

Cris70 commented 6 months ago

...and updated the fix, with PR #296