search

linuxmint / xapp

Cross-desktop libraries and common resources
GNU Lesser General Public License v3.0
127 stars 44 forks source link

Cannot build without NLS/translations #155

Open vishwin opened 2 years ago

vishwin commented 2 years ago

After mesonbuild/meson@8b573d7dc65bf20fcb0377ce4c56841496ad0c69, it is no longer possible to build without NLS/translations while mate-xapp-status-applet is unconditionally built since that uses i18n.merge_file() (which is not necessarily just for NLS purposes). Making mate-xapp-status-applet optional like #83 is one way to unbreak this.

eli-schwartz commented 2 years ago

it is no longer possible to build without NLS/translations

Was that ever officially supported? Maybe if you want this there should be a meson_options.txt option for it.

vishwin commented 2 years ago

Not sure, but prior to that meson commit it was possible to output such. Did mate-xapp-status-applet actually work as intended with msgfmt left out of the build environment? Who knows…

eli-schwartz commented 2 years ago 
<datadir>/mate-panel/applets/org.x.MateXAppStatusApplet.mate-panel-applet

would not get created with msgfmt left out of the build environment. So the applet would not work.