Closed bobby285271 closed 1 year ago
Same here, configured with meson setup -D buildtype=release
. The following patch fixes this problem (github won't let me add this as an attachment - "We don't support that file type" :man_shrugging:).
diff -pru xapp-2.6.0-orig/libxapp/xapp-debug.c xapp-2.6.0/libxapp/xapp-debug.c
--- xapp-2.6.0-orig/libxapp/xapp-debug.c 2023-06-01 11:17:06.000000000 +0200
+++ xapp-2.6.0/libxapp/xapp-debug.c 2023-06-02 21:06:04.203763532 +0200
@@ -22,6 +22,8 @@
* Copied from nemo
*/
+#ifdef ENABLE_DEBUG
+
#include <stdarg.h>
#include <glib.h>
@@ -127,3 +129,4 @@ xapp_debug_valist (DebugFlags flag,
}
}
+#endif
I gave --buildtype=debugoptimized a try and the build succeed, looking at this I wonder if we are encouraged to package in this way:
As the guy fielding bug reports, I'd recommend it - I think that was the point of 'debugoptimized' also. There's a little bit of detail under rule 4 here.
Hi,
We explicitly pass
--buildtype=plain
on all NixOS meson builds by default and the 2.6.0 build failed for me:Here is the full log:
With a brief look this is likely the case when
ENABLE_DEBUG
is not enabled,https://github.com/linuxmint/xapp/blob/c94f0b05afa8fd8f5cebbfc07a931bb77ed80e53/meson.build#L18
I gave
--buildtype=debugoptimized
a try and the build succeed, looking at this I wonder if we are encouraged to package in this way:https://github.com/linuxmint/xapp/blob/ced7f6b35e7fc12d604adf9482035950bccc2875/meson.build#L4