linuxmint / xapp

Cross-desktop libraries and common resources
GNU Lesser General Public License v3.0
126 stars 44 forks source link

Fix meson.build deprecations up to 0.56.0 #172

Closed rcalixte closed 11 months ago

rcalixte commented 11 months ago

Similar to linuxmint/cinnamon#11870 Similar to linuxmint/cinnamon-control-center#318 Similar to linuxmint/cinnamon-desktop#234 Similar to linuxmint/cinnamon-menus#67 Similar to linuxmint/cinnamon-screensaver#444 Similar to linuxmint/cinnamon-session#155 Similar to linuxmint/cinnamon-settings-daemon#383 Similar to linuxmint/cjs#119 Similar to linuxmint/muffin#675 Similar to linuxmint/nemo#3316 Similar to linuxmint/nemo-extensions#496

Fantu commented 11 months ago

hi, in this and probably others PR is missed meson required version (meson_version: '>=0.56.0' in meson.build) in packaging can be not increased as latest debian stable and ubuntu LTS (for mint) that have major version but I think at least version in meson.build is useful for other distro older or users that want do backports

rcalixte commented 11 months ago

hi, in this and probably others PR is missed meson required version (meson_version: '>=0.56.0' in meson.build) in packaging can be not increased as latest debian stable and ubuntu LTS (for mint) that have major version but I think at least version in meson.build is useful for other distro older or users that want do backports

Meson 0.56.0 was released in October 2020:

Are there any older distributions that need to backport beyond those bases?

Fantu commented 11 months ago

there isn't only debian and ubuntu, I suggest to add meson_version: '>=0.56.0' in meson.build anyway so any user that try to build with older meson understands that's the problem

rcalixte commented 11 months ago

there isn't only debian and ubuntu, I suggest to add meson_version: '>=0.56.0' in meson.build anyway so any user that try to build with older meson understands that's the problem

Ah, I think I misunderstood you initially. Done. I also checked the others. Thanks for the review!