linuxmint / xed

X-Apps [Text] Editor (Cross-DE, backward-compatible, GTK3, traditional UI)
GNU General Public License v2.0
448 stars 84 forks source link

"Mouse wheel scrolling to change tabs" is the wrong way relative to Caja and Xfce's panel #596

Open NintendoManiac64 opened 1 year ago

NintendoManiac64 commented 1 year ago
 * Xed v3.4.3
 * Mint 21.2

Issue In Xed, the scrolling direction is reversed relative to Caja. That is, in Xed, scrolling down switches to the tab on the left while scrolling up switching to the tab on the right.

But in Caja, scrolling the mouse wheel down switches to the tab to the right while scrolling up switches to the tab to the left. This is also the case with the panel in Xfce when using the scroll wheel to switch between open windows.

Steps to reproduce Open multiple tabs in Xed, put your mouse pointer on the tab bar, and scroll the scroll wheel.

Expected behaviour Scrolling the mouse wheel down should switch to the tab on the right while scrolling the mouse wheel up should switch to the tab on the left.

Other information In Caja (also Nemo and Thunar), if you have a long folder path open that is longer than can properly fit into the current window size, scrolling down scrolls the path bar to the right while scrolling up scrolls to the path bar to the left. Similarly, Ctrl+PageDown in Caja (also Nemo, Thunar, and Firefox) switches to the tab on the right while Ctrl+PageUp switches to the tab to the left, and obviously PageDown is analogous to scrolling down while PageUp is analogous to scrolling up.

Also in Firefox and, by definition, Caja (because scrolling changed tabs), when the tab bar becomes too full and overflows, scrolling down scrolls the entire tab bar to the right while scrolling up scrolls the entire tab bar to the left.

Relevant issue: https://github.com/linuxmint/xed/issues/519

quiddity-wp commented 5 months ago

It looks like the relevant code is here, and a Fix might involve just swapping lines L651 and L655? [Disclaimer: NotADev!] https://github.com/linuxmint/xed/blob/master/xed/xed-notebook.c#L651-L655

Thank you to whomever can fix it! [or tell us how to quick-fix-it locally, in a stable way, ourselves!]

ghost commented 1 month ago

I agree, it's really annoying especially since Chromium does the opposite.